Return-Path: Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: (qmail 60208 invoked from network); 17 Apr 2007 12:38:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Apr 2007 12:38:59 -0000 Received: (qmail 52393 invoked by uid 500); 17 Apr 2007 12:39:05 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 52271 invoked by uid 500); 17 Apr 2007 12:39:05 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 52259 invoked by uid 99); 17 Apr 2007 12:39:05 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2007 05:39:05 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [203.202.1.123] (HELO barge.anchor.net.au) (203.202.1.123) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2007 05:38:58 -0700 Received: from [127.0.0.1] (dsl-58-6-32-215.nsw.westnet.com.au [58.6.32.215]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by barge.anchor.net.au (Postfix) with ESMTP id 153CC10101 for ; Tue, 17 Apr 2007 22:39:16 +1000 (EST) Message-ID: <4624BEF4.6060208@backstagetech.com.au> Date: Tue, 17 Apr 2007 22:35:00 +1000 From: Scott Eade User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Apache Torque Developers List Subject: Re: ECM Issue (Was: Re: [jira] Resolved: (TORQUE-68) DatabaseMap remains empty if Torque is stopped and restarted, causes NPEs) References: <30454439.1176553816702.JavaMail.jira@brutus> <20070415015229.L70611@minotaur.apache.org> <46224F40.6020909@apache.org> <4624605E.6090707@backstagetech.com.au> <462467B0.7060101@backstagetech.com.au> <4624737E.70603@tewisoft.de> <46247EF4.2080608@tewisoft.de> In-Reply-To: <46247EF4.2080608@tewisoft.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Thomas Vandahl wrote: > Hi Scott, > > Thomas Vandahl wrote: > >> Scott, would you please check the following for me: Remove the >> SingleThreaded entry from the implements line of TorqueComponent and >> if that doesn't help, replace it with ThreadSafe. Then check again. > > After looking at the decommission() method in > > http://svn.apache.org/viewvc/excalibur/tags/excalibur-component-2.1-Release/deprecated/component/src/java/org/apache/avalon/excalibur/component/DefaultComponentFactory.java?revision=264009&view=markup > > I'm pretty sure that marking TorqueComponent as ThreadSafe again would > cure the problem. In the method code attached you can see the log > message you observed and a call to > > ContainerUtil.dispose( decommissionComponent ); > > which is exactly what happens. > > Please check the change nevertheless, to be sure. Yes you are right - switching from implementing SingleThreaded to ThreadSafe results in the component no longer being decommissioned and subsequent queries execute correctly. Well spotted! Does this change have any other implications? Scott --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org