db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Fischer <tfisc...@apache.org>
Subject Re: [PATCH] Maven2 Plugin
Date Sat, 30 Dec 2006 14:19:55 GMT
I have cheked your patch against the test project and it works fine. The 
@execute phase="generate-sources" started a forked lifecycle which is not 
necessary for the om goal. The @requiresDependencyResolution is also not 
necessary. In the attached patch it is disabled by changing the annotation 
to a unknown attribute, however It would be cleaner to remove it 
completely as in

  * @goal om
- * @execute phase="generate-sources"
- * @requiresDependencyResolution compile
+ * @phase generate-sources
  */

Please commit your patch, I can also do it if you prefer that.

     Thomas

On Sun, 17 Dec 2006, Jeffrey D. Brekke wrote:

> below is a small patch to the OM mojo in torque.  I haven't committed in a 
> while on the project, and am not *that* familiar with the plugins for maven2, 
> but there seems to be a typo which prevents the om goal to integrate with the 
> maven2 lifecycle.  All the other goals seem fine. This does work here when I 
> rebuild the plugin using these settings.
>
> Could someone review and try it?
>
> ----
>
> Index: src/main/java/org/apache/torque/mojo/OMMojo.java
> ===================================================================
> --- src/main/java/org/apache/torque/mojo/OMMojo.java    (revision 488127)
> +++ src/main/java/org/apache/torque/mojo/OMMojo.java    (working copy)
> @@ -32,8 +32,8 @@
>  * @author <a href="fischer@seitenbau.de">Thomas Fischer</a>
>  *
>  * @goal om
> - * @execute phase="generate-sources"
> - * @requiresDependencyResolution compile
> + * @phase generate-sources
> + * @requires DependencyResolution compile
>  */
> public class OMMojo
>         extends DataModelTaskMojo
>
> -- 
> =====================================================================
> Jeffrey D. Brekke                                   jbrekke@wi.rr.com
> Wisconsin,  USA                                     brekke@apache.org
>                                                    ekkerbj@yahoo.com
> http://www.bloglines.com/blog/jbrekke               ekkerbj@gmail.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: torque-dev-help@db.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message