Return-Path: Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: (qmail 58667 invoked from network); 11 Nov 2006 12:12:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Nov 2006 12:12:00 -0000 Received: (qmail 19139 invoked by uid 500); 11 Nov 2006 12:12:10 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 19116 invoked by uid 500); 11 Nov 2006 12:12:10 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 19074 invoked by uid 99); 11 Nov 2006 12:12:10 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Nov 2006 04:12:10 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Nov 2006 04:11:58 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 62B5C714313 for ; Sat, 11 Nov 2006 04:11:38 -0800 (PST) Message-ID: <31929883.1163247098401.JavaMail.jira@brutus> Date: Sat, 11 Nov 2006 04:11:38 -0800 (PST) From: "Thomas Fischer (JIRA)" To: torque-dev@db.apache.org Subject: [jira] Commented: (TORQUE-65) Test Project Testcase: DataTest.testSubqueries fails with MySQL 4.0 In-Reply-To: <5146456.1163114317086.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/TORQUE-65?page=comments#action_12448966 ] Thomas Fischer commented on TORQUE-65: -------------------------------------- This is a known issue (hm, probably only known to me :-( ) The best thing to do in the test would be to ask mysql whether it is mysql4 or mysql5. According to the docs, this should be possible by issuing the sql command show variables like "version"; If it is mysql4 and the test fails, print an error. If its mysql5 and the test fails, fail. In my opionion, there is no need to ask the DB adaptor whether subselects are supported. If they are not supported, an error will be thrown no matter whether the adaptor knows whether the db supports subselects or not (in the first case, the error would be thrown by torque's sql generation process, in the latter case, it will be thrown by the database). So this does not make any difference to the user. > Test Project Testcase: DataTest.testSubqueries fails with MySQL 4.0 > ------------------------------------------------------------------- > > Key: TORQUE-65 > URL: http://issues.apache.org/jira/browse/TORQUE-65 > Project: Torque > Issue Type: Bug > Components: Test Project > Affects Versions: 3.2.1 > Reporter: CG Monroe > Priority: Minor > > MySQL 4.0 does not support subselect (and some other Torque supported DBs). But the testSubqueries testcase uses them. This should not be an error or failure condition. > Should this just catch exceptions and print a warning or does there need to be a "support subselects" option on DBAdaptors (and MySQL 4.0 / 5.0 adaptor)? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org