db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Vandahl ...@apache.org>
Subject Re: svn commit: r424794 - in /db/torque/runtime/trunk: src/java/org/apache/torque/ src/java/org/apache/torque/adapter/ src/test/ src/test/org/apache/torque/ xdocs/reference/
Date Tue, 01 Aug 2006 20:17:49 GMT
Thomas Fischer wrote:
> Thomas,
> 
> Although I'm +1 on the solution for customizable adapters, the 
> implementation could be slightly improved in my eyes. The method 
> DBFactory.create(String) throws an exception in the case where a custom 
> DB adapter is used. I am in favour of not throwing exceptions if a legal 
> condition occurs, so I'd rather return null in the method. I can do it 
> if you do not mind.

I guess this is a matter of taste. I do not consider exceptions to be 
"evil" actually. Feel free to change it.

> Would you also mind to add some documentation to the 
> initialisation-configuration.xml in the runtime reference ? This is 
> where (hopefully) all runtime configuration settings should be explained.


I added some stuff to the new-database-support.xml as you probably 
noticed. You can re-use that if you like.

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message