Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: Velocity Templates
Date: Mon, 10 Jul 2006 09:43:18 +0200
Message-ID: 
 <F1EF69E69C1EED4FA3BB295B07664EEE52375B@srv-master.cadooz-ag.intern>
Thread-Topic: Velocity Templates
Thread-Index: Acaj9HoumxCbZq5WT0a/6T6XZ2wxsA==
From: "Thoralf Rickert" <thoralf.rickert@cadooz.de>
To: "Apache Torque Developers List" <torque-dev@db.apache.org>

Hi!

I think there is an open discussion thread (in 2005) about the generated
code style in the Base* classes but I can't find it. The "problem" is
that the generated code looks a little bit ugly because of too many
spaces. This is a velocity problem, because of leading spaces in front
of velocity commands like #if and #end.

We've the same problem in one of our projects where we use velocity
templates to render XHTML pages. There I made a small patch in our
VelocityTemplateLoader to generate better code.=20

Here is an example of a template:
 public void helloWorld()
 {
   #if($useLog)
     log.debug("Hello World called");
   #else
     System.out.println("Hello World called");
   #end
 }

These leading spaces makes the code "unattractive" and sometimes
unreadable. The patch is to remove any leading spaces in front of any
velocity command. It's a line-by-line replacement regex with "^\s#" to
"#". The result that is send to the renderer looks like this.

 public void helloWorld()
 {
#if($useLog)
     log.debug("Hello World called");
#else
     System.out.println("Hello World called");
#end
 }


The solution is simple but doesn't fix every problem. Of course this
could generate other problems. For example the following code compiles
well without the patch.

But with the patch it creates a velocity compile error, because of
missing output between #if and #else

 public void helloWorld()
 {
   #if($useLog)
   #else
     System.out.println("Hello World called");
   #end
 }

If you're interested in such a patch I would make it for the
torque-generator.

bye
Thoralf


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org