db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Federico Fissore (JIRA)" <j...@apache.org>
Subject [jira] Created: (TORQUE-42) Criteria.andDate missing getTime() method call
Date Wed, 12 Jul 2006 11:31:29 GMT
Criteria.andDate missing getTime() method call
----------------------------------------------

         Key: TORQUE-42
         URL: http://issues.apache.org/jira/browse/TORQUE-42
     Project: Torque
        Type: Bug

  Components: Runtime  
    Versions: 3.2    
 Environment: java5, tomcat 5.5.17
    Reporter: Federico Fissore
     Fix For: 3.2
 Attachments: Criteria-3.2.patch

Hello all,

there is a bug in Criteria.andDate: the call to the method getTime() is missing while it is
present in Criteria.addDate

To exploit it use a code like

calendar.setTime(new Date());
crit.addDate(GpsLocationPeer.LAST_UPDATE, calendar.get(Calendar.YEAR), calendar.get(Calendar.MONTH),
calendar.get(Calendar.DAY_OF_MONTH), Criteria.GREATER_EQUAL);

calendar.add(Calendar.DAY_OF_MONTH, 1);
crit.andDate(GpsLocationPeer.LAST_UPDATE, calendar.get(Calendar.YEAR), calendar.get(Calendar.MONTH),
calendar.get(Calendar.DAY_OF_MONTH), Criteria.LESS_THAN);

This leads to a SQLException due to incorrect sql query creation.
That is easy to see with Criteria.toString()

Adding the missing method call solves the problem

Please, check the attached patch. Thank you

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message