db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Goulet (JIRA)" <j...@apache.org>
Subject [jira] Created: (TORQUE-25) LimitHelper.java doesn't handle Sybase DBMS
Date Thu, 01 Jun 2006 02:23:29 GMT
LimitHelper.java doesn't handle Sybase DBMS
-------------------------------------------

         Key: TORQUE-25
         URL: http://issues.apache.org/jira/browse/TORQUE-25
     Project: Torque
        Type: Improvement

  Components: Runtime  
    Versions: 3.2    
 Environment: All
    Reporter: Martin Goulet
     Fix For: 3.2.1


> I've noticed that the DB.java class contains the constant to define 
> limits (Criteria.setLimit() etc) for the Sybase database 
> (LIMIT_STYLE_SYBASE). However the LimitHelper.java class doesn't make 
> use of it (excerpt from the buidLimit method):
>
>
>
>      ...
>
>        if (offset > 0 || limit > 0)
>        {
>            // If we hit a database type, that is able to do native
>            // limiting, we must set the criteria values to -1 and 0
>            // afterwards. Reason is, that else theexecuteQuery
>            // method tries to do the limiting using Village
>            //
>
>            switch (db.getLimitStyle())
>            {
>            case DB.LIMIT_STYLE_MYSQL :
>                LimitHelper.generateMySQLLimits(query, offset, limit);
>                break;
>
>            case DB.LIMIT_STYLE_POSTGRES :
>                LimitHelper.generatePostgreSQLLimits(query, offset,  limit);
>                break;
>
>            case DB.LIMIT_STYLE_ORACLE :
>                LimitHelper.generateOracleLimits(query, offset, limit);
>                break;
>
>            case DB.LIMIT_STYLE_DB2 :
>                LimitHelper.generateDB2Limits(query, offset, limit);
>                break;
>
>            default:
>                if (db.supportsNativeLimit())
>                {
>                    query.setLimit(String.valueOf(limit));
>                }
>                break;
>            }
>
>      ...
>
>
>
> You notice that there is no case for Sybase (DB.LIMIT_STYLE_SYBASE).


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message