Return-Path: Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: (qmail 85864 invoked from network); 5 Feb 2006 22:04:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Feb 2006 22:04:05 -0000 Received: (qmail 18468 invoked by uid 500); 5 Feb 2006 22:04:05 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 18452 invoked by uid 500); 5 Feb 2006 22:04:04 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 18441 invoked by uid 99); 5 Feb 2006 22:04:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Feb 2006 14:04:04 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 05 Feb 2006 14:04:03 -0800 Received: (qmail 85157 invoked by uid 1977); 5 Feb 2006 22:03:43 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 5 Feb 2006 22:03:43 -0000 Date: Sun, 5 Feb 2006 14:03:43 -0800 (PST) From: Thomas Fischer To: Apache Torque Developers List cc: Carsten.Wenderdel@lexisnexis.de Subject: Re: Mistakes in JavaDoc of Criteria In-Reply-To: <1AA5D27AA55D744E9E828F4AED2E87C2065E2D6D@lngmueexc01.lexisnexis.de> Message-ID: <20060205140235.T81743@minotaur.apache.org> References: <1AA5D27AA55D744E9E828F4AED2E87C2065E2D6D@lngmueexc01.lexisnexis.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Rating: localhost 1.6.2 0/1000/N X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Thanks a lot for noting that. I'll correct it. Thomas On Wed, 1 Feb 2006, Wenderdel, Carsten (LNG-MUE) wrote: > Hi, > > I'm not sure whether this is the proper place or it is an unknown issue - if > not I apologize. > > I just read the API > http://db.apache.org/torque/runtime/apidocs/org/apache/torque/util/Criteria. > html and have found some mistakes. > > For example the method > public Criteria add(java.lang.String column, > java.lang.Object value, > SqlEnum comparison) > is commented: > > If is used as follow: > Criteria crit = new Criteria().add("column", "value", > "Criterion.GREATER_THAN"); > > This should be wrong as comparison is an object of SQLEnum and not of > String. Furthermore Criterion has not a static field "GREATER_THAN", so imo > it should be: > > This is used as follows: > Criteria crit = new Criteria().add("column", "value", > Criteria.GREATER_THAN); > > > This applies also to following methods: > > public Criteria add(java.lang.String table, > java.lang.String column, > java.lang.Object value, > SqlEnum comparison) > > public Criteria and(java.lang.String column, > java.lang.Object value, > SqlEnum comparison) > > public Criteria and(java.lang.String table, > java.lang.String column, > java.lang.Object value, > SqlEnum comparison) > > public Criteria or(java.lang.String column, > java.lang.Object value, > SqlEnum comparison) > > public Criteria or(java.lang.String table, > java.lang.String column, > java.lang.Object value, > SqlEnum comparison) > > Regards, Carsten > > --------------------------------------------------------------------- > To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org > For additional commands, e-mail: torque-dev-help@db.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org