Hi,
Based on your patch, I have just added scale support to the
TorqueJDBCTransformTask. I have changed the following things:
- I have used the scale attribute in the xml rather than the comma
notation.
- the scale is just added for columns with jdbc type decimal and numeric,
not for strings, and only if it is greater than 0.
- I have retained the longvarchar column type to generate a size
attribute. Perhaps it makes no sense to generate the size attribute for
longvarchars, but this may be different for different databases.
Please use diff -u the next time. This will make it easier to apply the
patch.
Thanks again for submitting the patch,
Thomas
On Thu, 6 Oct 2005, Hilco Wijbenga wrote:
> Since I am not allowed to add issues to Scarab, I will just send the
> issue and fix here.
>
> I noticed that the jdbc Ant target did not create DECIMAL and NUMERIC
> columns correctly. It would create, e.g.,
>
> <column name="price" size="19" type="DECIMAL"/>
>
> instead of
>
> <column name="price" size="19,2" type="DECIMAL"/>
>
> I had a look in the code (TorqueJDBCTransformTask.java) and I think my
> attached changes fix the problem (i.e., works for me :-) ).
>
> Bye,
> Hilco
>
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
|