Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <42F771C6.7000002@bluesunrise.com>
Date: Mon, 08 Aug 2005 07:52:54 -0700
From: David Sean Taylor <david@bluesunrise.com>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: Apache Torque Developers List <torque-dev@db.apache.org>
Subject: Re: [patch] MySQL SQL generation fix
References: <dcvh19$9u0$1@tangens.hometree.net>
 <42F63AF2.4040607@bluesunrise.com> <dd75lv$92c$2@tangens.hometree.net>
In-Reply-To: <dd75lv$92c$2@tangens.hometree.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Henning P. Schmiedehausen wrote:
> David Sean Taylor <david@bluesunrise.com> writes:
> 
> 
>>When we upgraded to Torque version 3.2-rc1, Torque incorrectly 
>>generating MySQL statements for MEDIUMTEXT as
> 
> 
>>    COLUMN_VALUE MEDIUMTEXTNOT NULL,
> 
> 
> Right. This is a bug.
> 
I would have logged it but I couldn't find a Torque project under Apache 
JIRA
Has Torque migrated to JIRA yet?

> 
>>src/generator/src/java/org/apache/torque/engine/database/model/Column.java 
>> 27 Jun 2005 21:34:10 -0000      1.29
>>+++ 
>>src/generator/src/java/org/apache/torque/engine/database/model/Column.java 
>> 5 Aug 2005 06:42:27 -0000
> 
> 
> Please move to the subversion repository in the future.

Didn't realize that you migrated to subversion.
I now see that the site links point to subversion and not cvs.
That must have been recent...

> 
> While your patch fixes a symptom, it does not cure the deeper,
> underlying problems of getSqlString() which is sort of a "let's juggle
> with spaces somehow" method.
> 
> I just checked in a fix that should repair all problems with that
> method for good.
> 
> If you do work with MySQL; it would be nice to have a domain test
> class for MySQL like we have for other databases. This would help us
> spot such errors faster.

Sure, I'll look into it.

Do you plan on releasing anytime soon?
We'd like to incorporate the bug fix in our projects, and base our 
projects on an official torque release or at least an RC

Thanks,

-- 
David Sean Taylor
Bluesunrise Software
david@bluesunrise.com
[office] +01 707 773-4646
[mobile] +01 707 529 9194

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org