db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Fischer <fisc...@seitenbau.net>
Subject Re: cvs organisation: HEAD as active development branch
Date Tue, 15 Feb 2005 15:38:34 GMT




Thomas,

thanks for the reminder. I have reviewed the patch (first occurrence is in
the mail archives at
http://nagoya.apache.org/eyebrowse/ReadMsg?listName=torque-user@db.apache.org&msgNo=1111),
 and I am unsure whether I should commit it. I do not use LargeSelect
myself, and have no idea of its uses. It seems to me that a
ConcurrentModificationException can only be raised if two query threads are
launched at the same time for the same LargeSelect. In this case, I am not
sure whether it suffices to synchronize the access to the results object,
or whether only one select thread should be active at a time. (I do not
know whether it is desired that one query thread can possibly change the
results of another running query thread).
I'd value Scott's comment on this before I do anything.

Regarding the ObjectWithManager patch, I am reluctant to commit the manager
patch without a testcase, because I do not use the manager myself and have
no experience with it. I have even seen the runtimetest fail with the cache
switched on, and therefore consider it buggy. Do you use it in production ?

Either some other committer who is more experienced than me in usinfg the
cache is willing to commit this, or I'd rather see a scarab issue opened
and have either a testcase or a detailed description of the faulty
behaviour.

   Thanks,

        Thomas

Thomas Vandahl <thomas.vandahl@tewisoft.de> schrieb am 15.02.2005 14:56:43:

> Hi Thomas
>
> Thomas Fischer wrote:
> > I will commit the patch in the next days. Remind me if I forget it.
> Reminder! :-)
>
> As you are at it: I've got one more thing to patch. I found that the
> latest generator templates do not generate a cache update during
> save(con) correctly because of a failing #set statement. Diff attached.
>
> Bye, Thomas.
>
> --- ObjectWithManager.vm.orig   Tue Feb 15 14:36:14 2005
> +++ ObjectWithManager.vm   Tue Feb 15 14:36:40 2005
> @@ -1107,7 +1107,11 @@
>                      ${table.JavaName}Peer.doUpdate(($table.
> JavaName) this, con);
>                  }
>
> -  #set ($tableHasPrimaryKey = $table.PrimaryKey.size() > 0)
> +  #if ($table.PrimaryKey.size() > 0)
> +    #set ($tableHasPrimaryKey = "true")
> +  #else
> +    #set ($tableHasPrimaryKey = "false")
> +  #end
>    #if ($tableHasPrimaryKey)
>      #set ($interfaceName = $table.JavaName)
>      #if ($table.Interface)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: torque-dev-help@db.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message