Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Received-SPF: pass (hermes.apache.org: local policy)
To: torque-dev@db.apache.org
Path: not-for-mail
From: "Henning P. Schmiedehausen" <hps@intermeta.de>
Newsgroups: hometree.jakarta.torque.dev
Subject: Re: Patch TQRS219
Date: Thu, 21 Oct 2004 13:08:15 +0000 (UTC)
Organization: INTERMETA - Gesellschaft fuer Mehrwertdienste mbH
Lines: 59
Message-ID: <cl8cbv$9au$1@tangens.hometree.net>
References: <cl6rqs$dm9$1@tangens.hometree.net>
 <OFD33B6FFA.17EA844F-ONC1256F34.0044AE05-C1256F34.0045A68E@seitenbau.net>
Reply-To: hps@intermeta.de
NNTP-Posting-Host: forge.intermeta.de
NNTP-Posting-Date: Thu, 21 Oct 2004 13:08:15 +0000 (UTC)
User-Agent: nn/6.6.5

Thomas Fischer <Fischer@seitenbau.net> writes:

Everything that clears up the logic in the BasePeer is a good
thing. It would be nice if we get some unit test that check the
behaviour "before" and "after" to make sure that the patch does not
break anything.

The TORQUE_3_1_HENNING branch is intended to be a "full speed ahead
and damn the torpedoes" branch which does not look for backward
compatibility. I intended to merge parts of it that have proven to
work fine back into 3.2 or 3.1.x. 

As far as I understand, the Join patch just extends the functionality
of the Per. Or are there any incompatible changes in it?

	Regards
		Henning


>Hi,

>It seems that I cannot post a comment to the ticket, so my comment goes
>here.

>I do not see this patch in the 3.1.1 release, because there exists no
>documentation at the moment and because the patch would have to be adjusted
>to the changes in BasePeer which have been applied to CVS since the patch.

>At the moment, it seems that after the 3.1.1 release is out, I will have
>time to rework the patch and write some documentation.

>Henning, I just wonder whether you agree with the appoach I have taken in
>BasePeer, which is to split the method createQuery() and
>createPreparedStatement() into several methods, i.e. processJoins()...,
>processModifiers()... , and whether that collides with anything you have
>done in your 3_1_HENNING-Branch.

>   Thomas


>---------------------------------------------------------------------
>To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
>For additional commands, e-mail: torque-dev-help@db.apache.org

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

"Fighting for one's political stand is an honorable action, but re-
 fusing to acknowledge that there might be weaknesses in one's
 position - in order to identify them so that they can be remedied -
 is a large enough problem with the Open Source movement that it
 deserves to be on this list of the top five problems."
                       -- Michelle Levesque, "Fundamental Issues with
                                    Open Source Software Development"

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org