From torque-dev-return-4288-apmail-db-torque-dev-archive=db.apache.org@db.apache.org Tue Aug 10 10:10:46 2004 Return-Path: Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: (qmail 94608 invoked from network); 10 Aug 2004 10:10:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 10 Aug 2004 10:10:46 -0000 Received: (qmail 61638 invoked by uid 500); 10 Aug 2004 10:10:39 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 61579 invoked by uid 500); 10 Aug 2004 10:10:36 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 61557 invoked by uid 99); 10 Aug 2004 10:10:34 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received: from [212.67.96.159] (HELO msgdirector3.onetel.net.uk) (212.67.96.159) by apache.org (qpsmtpd/0.27.1) with ESMTP; Tue, 10 Aug 2004 03:10:31 -0700 Received: from bolek.coachhouse (213-78-102-76.friaco.onetel.net.uk [213.78.102.76]) by msgdirector3.onetel.net.uk (MOS 3.4.6-GR) with ESMTP id COS71926; Tue, 10 Aug 2004 11:10:17 +0100 (BST) Received: (Exim 3.36) #1 (Debian)) protocol: esmtp id 1BuTZs-0004oZ-00 ; Tue, 10 Aug 2004 11:09:56 +0100 Message-ID: <41189EF3.5080707@numerixtechnology.de> Date: Tue, 10 Aug 2004 11:09:55 +0100 From: T E Schmitz Reply-To: mailreg@numerixtechnology.de User-Agent: Mozilla Thunderbird 0.7 (Windows/20040616) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Apache Torque Developers List , Fischer@seitenbau.net Subject: Re: submitted patch which allows left joins, right joins and explicit inner joins References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Hello Thomas >>It certainly is cleaner if SqlEnum remains non-public. However, if you >>wanted to parameterize the join methods with Criteria.LEFT_JOIN, etc. >>then the parameter would have to be an SqlEnum and hence have to be > public. > > Sorry, I did not think thoroughly about it. Of course you are right, > because what you want is not an instance of SqlEnum, but you want to > declare a parameter of the type SQLEnum, which is quite a difference. I also something else in the back of my mind - but I do not expect this to be considered for Torque: I decided to use the Joda-Time API (http://joda-time.sourceforge.net) for DATE and TIME properties (this API is hugely more powerful than java.util.Date and, most of all, it allows you to distinguish between DateOnly and TimeOnly). But as I am now using org.joda.time.DateOnly instead of java.util.Date in the generated code I was forced to subclass Criteria and override all methods which take a data object of some kind, check for DateOnly and convert to Date. Some of the methods take an SqlEnum for a parameter and if not for the joins I needed to make SqlEnum public for this exercise. As I say, I don't expect this to be as a matter of general interest. Joda-time is open source but not part of the Jakarta project anyway. But the concept is certainly interesting. > Forgive me ;-) ;-) -- Regards/Gruß, Tarlika --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org