db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Fischer <Fisc...@seitenbau.net>
Subject Re: submitted patch which allows left joins, right joins and explicit inner joins
Date Tue, 10 Aug 2004 09:52:45 GMT





Hi Tarlika,

T E Schmitz <mailreg@numerixtechnology.de> schrieb am 10.08.2004 11:33:45:

> Hello Thomas,
>
> Thomas Fischer wrote:
>
> > T E Schmitz <mailreg@numerixtechnology.de> schrieb am 06.08.2004
17:53:35:
> >
> >>Note that this requires SqlEnum to be public!
> >>
> >
> > Most of the SqlEnum constants are made available as public constants in
the
> > Criteria object (e.g. Criteria.LEFT_JOIN is a SqlEnum Object), so I do
not
> > see the reason why you had to make SqlEnum public .....  As one
> usually wants only one
> > access point to avoid confusion, the SqlEnum is not public. In my
opinion,
> > this is a correct decision.
>
> It certainly is cleaner if SqlEnum remains non-public. However, if you
> wanted to parameterize the join methods with Criteria.LEFT_JOIN, etc.
> then the parameter would have to be an SqlEnum and hence have to be
public.

Sorry, I did not think thoroughly about it. Of course you are right,
because what you want is not an instance of SqlEnum, but you want to
declare a parameter of the type SQLEnum, which is quite a difference.
Forgive me ;-)


Thomas


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message