db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Scott Eade <se...@backstagetech.com.au>
Subject Re: Findbugs Patch for 3.1.1
Date Thu, 26 Aug 2004 03:03:22 GMT
Henning P. Schmiedehausen wrote:
<snip/>

>There
>are some a == b checks where a and b are Strings in the peers
>  
>
<snip/>

>Index: src/generator/src/templates/om/Peer.vm
>===================================================================
>--- src/generator/src/templates/om/Peer.vm	(revision 2582)
>+++ src/generator/src/templates/om/Peer.vm	(working copy)
>  
>
<snip/>

>-        // Set the correct dbName if it has not been overridden
>-        // criteria.getDbName will return the same object if not set to
>-        // another value so == check is okay and faster
>-        if (criteria.getDbName() == Torque.getDefaultDB())
>-        {
>-            criteria.setDbName(DATABASE_NAME);
>-        }
>+        setDbName(criteria);
>+
>  
>
<snip/>

>+
>+  private static void setDbName(Criteria crit)
>+  {
>+    if (crit != null && crit.getDbName() != null)
>+    {
>+      if (crit.getDbName().equals(Torque.getDefaultDB()))
>+      {
>+        crit.setDbName(DATABASE_NAME);
>+      }
>+    }
>+  }
>  
>
Is the removed comment not true?

Scott

-- 
Scott Eade
Backstage Technologies Pty. Ltd.
http://www.backstagetech.com.au


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message