From torque-dev-return-3740-apmail-db-torque-dev-archive=db.apache.org@db.apache.org Tue Dec 02 20:54:20 2003 Return-Path: Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: (qmail 84722 invoked from network); 2 Dec 2003 20:54:20 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 2 Dec 2003 20:54:20 -0000 Received: (qmail 79200 invoked by uid 500); 2 Dec 2003 20:54:09 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 79014 invoked by uid 500); 2 Dec 2003 20:54:08 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 79001 invoked from network); 2 Dec 2003 20:54:08 -0000 Received: from unknown (HELO localhost.localdomain) (208.185.179.196) by daedalus.apache.org with SMTP; 2 Dec 2003 20:54:08 -0000 Received: from finemaltcoding.com (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.12.8/8.12.8) with ESMTP id hB2KruIT003624 for ; Tue, 2 Dec 2003 12:53:56 -0800 Message-ID: <3FCCFBE4.2080402@finemaltcoding.com> Date: Tue, 02 Dec 2003 12:53:56 -0800 From: Daniel Rall User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030701 X-Accept-Language: en, en-us, ko, ja MIME-Version: 1.0 To: Apache Torque Developers List Subject: Re: cvs commit: db-torque/src/generator/src/test/org/apache/torque/engine/database/model TableTest.java References: <20031201165630.16429.qmail@minotaur.apache.org> <3FCBF578.5040309@finemaltcoding.com> <3FCC53CF.7060304@marmot.at> In-Reply-To: <3FCC53CF.7060304@marmot.at> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Martin Poeschl wrote: > Daniel Rall wrote: > >> If you aren't going to dup() the lists, it should be documented that >> handles to the internal storage are being returned. > > that's what i expect it to do ... Why? Allowing modification to in the internal state of an object through use of its return values is an undocumented side effect. >> Otherwise, one could accidently modify the internal data structure >> without evening knowing it. > > there are more changes to come ... i'm nore sure if this will cause any > problems .. Side effects always cause problems. If not now, then later. --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org