db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Rall <...@finemaltcoding.com>
Subject Re: cvs commit: db-torque/src/generator/src/test/org/apache/torque/engine/database/model TableTest.java
Date Tue, 02 Dec 2003 20:53:56 GMT
Martin Poeschl wrote:
> Daniel Rall wrote:
> 
>> If you aren't going to dup() the lists, it should be documented that 
>> handles to the internal storage are being returned.  
> 
> that's what i expect it to do ...

Why?  Allowing modification to in the internal state of an object through use of 
its return values is an undocumented side effect.

>> Otherwise, one could accidently modify the internal data structure 
>> without evening knowing it.
> 
> there are more changes to come ... i'm nore sure if this will cause any 
> problems ..

Side effects always cause problems.  If not now, then later.



---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message