From seade@backstagetech.com.au Fri Nov 29 10:53:47 2002 Return-Path: Mailing-List: contact turbine-torque-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list turbine-torque-dev@jakarta.apache.org Received: (qmail 15343 invoked by uid 98); 30 Nov 2002 22:01:53 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Received: (qmail 15303 invoked from network); 30 Nov 2002 22:01:50 -0000 Received: from daedalus.apache.org (HELO apache.org) (63.251.56.142) by nagoya.betaversion.org with SMTP; 30 Nov 2002 22:01:50 -0000 Received: (qmail 98638 invoked by uid 500); 30 Nov 2002 22:00:40 -0000 Received: (qmail 98630 invoked from network); 30 Nov 2002 22:00:39 -0000 Received: from mta01bw.bigpond.com (139.134.6.78) by daedalus.apache.org with SMTP; 30 Nov 2002 22:00:39 -0000 Received: from [192.168.0.2] ([144.135.24.75]) by mta01bw.bigpond.com (Netscape Messaging Server 4.15 mta01bw Jul 16 2002 22:47:55) with SMTP id H6ET4X00.D0K for ; Sun, 1 Dec 2002 08:00:33 +1000 Received: from CPE-144-137-74-19.nsw.bigpond.net.au ([144.137.74.19]) by bwmam03.mailsvc.email.bigpond.com(MailRouter V3.0n 26/15225584); 01 Dec 2002 08:00:33 User-Agent: Microsoft-Entourage/10.1.1.2418 Date: Sun, 01 Dec 2002 09:01:06 +1100 Subject: Re: cvs commit: jakarta-turbine-torque/src/test/org/apache/torque/util CriteriaTest.java From: Scott Eade To: Turbine Torque Developers List Message-ID: In-Reply-To: <1038679638.22026.22.camel@localhost.localdomain> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > From: John McNally > > I would prefer package private, any reason that's not possible? > John, I have added a second patch to TRQS73 which uses the more correct package private visibility modifier (ore rather no visibility modifier). Can you please confirm that this is sufficient for you to revoke your -1. Thanks, Scott -- Scott Eade Backstage Technologies Pty. Ltd. http://www.backstagetech.com.au