db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arm...@apache.org
Subject svn commit: r472103 - /db/ojb/branches/OJB_1_0_RELEASE/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java
Date Tue, 07 Nov 2006 13:33:24 GMT
Author: arminw
Date: Tue Nov  7 05:33:23 2006
New Revision: 472103

URL: http://svn.apache.org/viewvc?view=rev&rev=472103
Log:
change result set count behavior. Seems latest driver support JDBC 2 correct

Modified:
    db/ojb/branches/OJB_1_0_RELEASE/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java

Modified: db/ojb/branches/OJB_1_0_RELEASE/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java
URL: http://svn.apache.org/viewvc/db/ojb/branches/OJB_1_0_RELEASE/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java?view=diff&rev=472103&r1=472102&r2=472103
==============================================================================
--- db/ojb/branches/OJB_1_0_RELEASE/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java
(original)
+++ db/ojb/branches/OJB_1_0_RELEASE/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java
Tue Nov  7 05:33:23 2006
@@ -172,12 +172,17 @@
 
     /**
      * Override default ResultSet size determination (rs.last();rs.getRow())
-     * with select count(*) operation
-     * SAP db doesn't let you use the .last, .getRow() mechanism (.getRow() will return -1)
+     * with select count(*) operation. Older maxDB/sapDB driver doesn't let you
+     * use the .last, .getRow() mechanism (.getRow() will return -1). But the latest
+     * ones seem to work correctly. So make sure to use the latest drivers to
+     * get the correct results.
      */
     public boolean useCountForResultsetSize()
     {
-        return true;
+        /*
+        arminw: current driver versions seems to support getRow correctly
+        */
+        return false;
     }
 
     public String createSequenceQuery(String sequenceName)



---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Mime
View raw message