db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jakob Braeuchi <jbraeu...@gmx.ch>
Subject Re: [PATCH] Fix ojb.delete-procedure include-pk-only
Date Fri, 10 Dec 2004 18:23:13 GMT
hi vadim,

the patch is in cvs now for trunk and branch.

jakob

Vadim Gritsenko schrieb:

> Hi All,
> 
> Attached is the small patch fixing problem with ojb.delete-procedure 
> include-pk-only attribute which currently does nothing because of 
> premature initialization of the includePkFieldsOnly field precluding 
> DeleteProcedureDescriptor from proper initialization:
> 
>     public final void addArgument(ArgumentDescriptor argument)
>     {
>         if (!this.getIncludePkFieldsOnly())
>         {
>             super.addArgument(argument);
>         }
>     }
> 
> 
> Patch is against OJB_1_0_RELEASE branch (this is the branch for 1.0.2, 
> right?). Can somebody apply it?
> 
> Thanks,
> Vadim
> 
> 
> ------------------------------------------------------------------------
> 
> Index: src/java/org/apache/ojb/broker/metadata/DeleteProcedureDescriptor.java
> ===================================================================
> RCS file: /home/cvspublic/db-ojb/src/java/org/apache/ojb/broker/metadata/DeleteProcedureDescriptor.java,v
> retrieving revision 1.7
> diff -u -r1.7 DeleteProcedureDescriptor.java
> --- src/java/org/apache/ojb/broker/metadata/DeleteProcedureDescriptor.java	13 Jun 2004
08:26:00 -0000	1.7
> +++ src/java/org/apache/ojb/broker/metadata/DeleteProcedureDescriptor.java	9 Dec 2004
20:23:22 -0000
> @@ -53,12 +53,12 @@
>          boolean includePkFieldsOnly)
>      {
>          super(classDescriptor, name);
> -        this.includePkFieldsOnly = includePkFieldsOnly;
> -        if (this.includePkFieldsOnly)
> +        if (includePkFieldsOnly)
>          {
>              this.addArguments(this.getClassDescriptor().getPkFields());
>              this.addArguments(this.getClassDescriptor().getLockingFields());
>          }
> +        this.includePkFieldsOnly = includePkFieldsOnly;
>      }
>  
>      //---------------------------------------------------------------
> 
> 
> 
> ------------------------------------------------------------------------
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Mime
View raw message