Return-Path: Delivered-To: apmail-db-ojb-dev-archive@www.apache.org Received: (qmail 15841 invoked from network); 7 Nov 2004 10:25:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 7 Nov 2004 10:25:36 -0000 Received: (qmail 34884 invoked by uid 500); 7 Nov 2004 10:25:35 -0000 Delivered-To: apmail-db-ojb-dev-archive@db.apache.org Received: (qmail 34851 invoked by uid 500); 7 Nov 2004 10:25:34 -0000 Mailing-List: contact ojb-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "OJB Developers List" Reply-To: "OJB Developers List" Delivered-To: mailing list ojb-dev@db.apache.org Received: (qmail 34833 invoked by uid 99); 7 Nov 2004 10:25:34 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of jbraeuchi@gmx.ch designates 213.165.64.20 as permitted sender) Received: from [213.165.64.20] (HELO mail.gmx.net) (213.165.64.20) by apache.org (qpsmtpd/0.28) with SMTP; Sun, 07 Nov 2004 02:25:33 -0800 Received: (qmail 21570 invoked by uid 65534); 7 Nov 2004 10:25:30 -0000 Received: from adsl-62-167-131-211.adslplus.ch (EHLO [192.168.1.10]) (62.167.131.211) by mail.gmx.net (mp024) with SMTP; 07 Nov 2004 11:25:30 +0100 X-Authenticated: #15507884 Message-ID: <418DF83F.6070700@gmx.ch> Date: Sun, 07 Nov 2004 11:26:07 +0100 From: Jakob Braeuchi User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.7.3) Gecko/20040910 X-Accept-Language: de, en MIME-Version: 1.0 To: OJB Developers List , Armin Waibel Subject: [OJB 1.1] inconsistent collections Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N hi all, i was having a look at our collection in package org.apache.ojb.broker.util.collections. i think we have a problem with the naming and implementation of these collection. ie. RemovalAwareCollection is actually a RemovalAware_Vector_ and thus a List. on the other side the RemovalAwareList is never used. imo we also use too much inheritance instead of using composition. so here's an opportunity for improvemnet/refactoring ;) jakob --------------------------------------------------------------------- To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org For additional commands, e-mail: ojb-dev-help@db.apache.org