Return-Path: Delivered-To: apmail-db-ojb-dev-archive@www.apache.org Received: (qmail 98999 invoked from network); 18 Aug 2004 18:39:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 18 Aug 2004 18:39:41 -0000 Received: (qmail 44224 invoked by uid 500); 18 Aug 2004 18:39:21 -0000 Delivered-To: apmail-db-ojb-dev-archive@db.apache.org Received: (qmail 44088 invoked by uid 500); 18 Aug 2004 18:39:20 -0000 Mailing-List: contact ojb-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "OJB Developers List" Reply-To: "OJB Developers List" Delivered-To: mailing list ojb-dev@db.apache.org Received: (qmail 43943 invoked by uid 99); 18 Aug 2004 18:39:18 -0000 X-ASF-Spam-Status: No, hits=1.5 required=10.0 tests=DNS_FROM_RFC_POST X-Spam-Check-By: apache.org Received: from [194.158.229.16] (HELO mail-fs.sunrise.ch) (194.158.229.16) by apache.org (qpsmtpd/0.27.1) with ESMTP; Wed, 18 Aug 2004 11:39:16 -0700 Received: from [192.168.1.10] (62.167.54.196) by mail-fs.sunrise.ch (7.0.028) id 40FFC89900596189 for ojb-dev@db.apache.org; Wed, 18 Aug 2004 20:39:13 +0200 Message-ID: <4123A273.70902@freesurf.ch> Date: Wed, 18 Aug 2004 20:39:47 +0200 From: Jakob Braeuchi User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.7.2) Gecko/20040803 X-Accept-Language: de, en MIME-Version: 1.0 To: OJB Developers List Subject: Informix- and SybasePlatform initializeJdbcConnection missing close Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N hi all, i recently ran findbugs over ojb and found some issues in the above platforms: this is the informix stuff: public void initializeJdbcConnection(JdbcConnectionDescriptor jcd, Connection conn) throws PlatformException { super.initializeJdbcConnection(jcd, conn); try { Statement stmt = conn.createStatement(); stmt.execute("SET LOCK MODE TO WAIT"); stmt.close(); <<< the close was missing } catch (SQLException e) { // ignore it } } the statement was not closed. i do not have these dbms installed, so i do not know whether the missing close is an error or not. i expect it to be an error, but i'm not sure. jakob --------------------------------------------------------------------- To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org For additional commands, e-mail: ojb-dev-help@db.apache.org