db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armin Waibel <arm...@apache.org>
Subject Re: YourKit Profiler for OJB
Date Wed, 21 Jul 2004 18:54:51 GMT
Hi Charles,

thanks for the detailed description.

Charles Anthony wrote:
...
> Anyway, OJB is holding on to far less of our objects - but it still is, a
> bit. All the PBLifeCycleEvents on PersistenceBrokerAbstractImpl (e.g.
> BEFORE_STORE_EVENT) have a target attribute, which is set when an event is
> fired, but never cleared. As Brokers are pooled, the targets are prevented
> from gc'd.
> 
> I've modified RsIterator and PersistenceBrokerImpl to reset the target after
> firing the event. I'm sure there is a better solution [2], but the simple
> approach works.

I like your simple approach more than [2], changing the 
'fireBrokerEvent' method signature.
Will check in your patched files ASAP.

regards,
Armin

> Cheers,
> 
> Charles.
> 
> 
> [1] Using JProfiler, from www.ej-technologies.com.
> [2] Perhaps modify 
> public void fireBrokerEvent(PersistenceBrokerEvent event) to be
> public void fireBrokerEvent(PersistenceBrokerEvent event, Object target){
>   event.setTarget(target);
>   ...
>   event.setTarget(null);
> }
> 
> 
>>-----Original Message-----
>>From: Brian McCallister [mailto:mccallister@forthillcompany.com]
>>Sent: 21 July 2004 11:54
>>To: OJB Developers List
>>Subject: YourKit Profiler for OJB
>>
>>
>>Hey all, the YourKit people( http://www.yourkit.com/ ) make a pretty 
>>decent profiler, and offer free licenses to open source projects. I 
>>have contacted them (I have been wanting to get hands on a good 
>>profiler to run OJB under for a while) and the deal is they will give 
>>each developer (committer) a license if we give them a mention in the 
>>credits part of our site.
>>
>>I'm all for it, personally.
>>
>>-Brian
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>>For additional commands, e-mail: ojb-dev-help@db.apache.org
>>
>>
> 
> 
> 
> ___________________________________________________________
> HPD Software Ltd. - Helping Business Finance Business
> Email terms and conditions: www.hpdsoftware.com/disclaimer 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Mime
View raw message