db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jakob Braeuchi <jbraeu...@gmx.ch>
Subject Re: [pathes]Arrays without initial size
Date Fri, 11 Jun 2004 19:17:03 GMT
hi robert,

this is a ptach i created using eclipse:

Index: Base64.java
===================================================================
RCS file: /home/cvs/db-ojb/src/java/org/apache/ojb/broker/util/Base64.java,v
retrieving revision 1.7
diff -u -r1.7 Base64.java
--- Base64.java	11 Jun 2004 19:06:35 -0000	1.7
+++ Base64.java	11 Jun 2004 19:15:21 -0000
@@ -288,7 +288,7 @@
       */
      private static byte[] encode3to4( byte[] threeBytes )
      {   return encode3to4( threeBytes, 3 );
-    }   // end encodeToBytes
+    }   // Test comment end encodeToBytes

jakob



Robert Sfeir wrote:

> By the way, I did the diff using cvs diff file.java >> file.txt
> 
> Should I be using a different method of doing the diff for patching?
> 
> Thanks
> R
> 
> On Jun 11, 2004, at 2:49 PM, Jakob Braeuchi wrote:
> 
>> hi robert,
>>
>> eclipse 3.0RC1 does not like the format of these patches, i had to  
>> apply the manually.
>>
>> how did you find the spots of interest ? do have a tool for this task ?
>>
>> jakob
>>
>> Robert Sfeir wrote:
>>
>>> I am trying to do this one file at a time to make it easier for whom  
>>> ever is going to check them in.
>>> There are roughly 270 spots to look at, I just did one package right  
>>> now the accesslayer package.
>>> While these are not bugs, I believe if we go through all these 
>>> spots,  we'll end up with some very nice speed improvements and in 
>>> some cases  memory improvements also.
>>> Hope this helps.
>>> R
>>> ---------------------------------------------------------------------- 
>>> -- 
>>> Index: BasePrefetcher.java
>>> ===================================================================
>>> RCS file:  
>>> /home/cvspublic/db-ojb/src/java/org/apache/ojb/broker/accesslayer/ 
>>> BasePrefetcher.java,v
>>> retrieving revision 1.9
>>> diff -r1.9 BasePrefetcher.java
>>> 159c159
>>> <      * @param pkField
>>> ---
>>>
>>>>     * @param field
>>>
>>> 165c165
>>> <         ArrayList values = new ArrayList();
>>> ---
>>>
>>>>        ArrayList values = new ArrayList(ids.size());
>>>
>>> 194c194
>>> <      * @param pkFields
>>> ---
>>>
>>>>     * @param fields
>>>>
>>>>
>>>> --------------------------------------------------------------------- 
>>>> ---
>>>>
>>>> Index: CollectionPrefetcher.java
>>>> ===================================================================
>>>> RCS file:  
>>>> /home/cvspublic/db-ojb/src/java/org/apache/ojb/broker/accesslayer/ 
>>>> CollectionPrefetcher.java,v
>>>> retrieving revision 1.28
>>>> diff -r1.28 CollectionPrefetcher.java
>>>> 73c73
>>>> <         Collection queries = new ArrayList();
>>>> ---
>>>>
>>>>>        Collection queries = new ArrayList(owners.size());
>>>>
>>>>
>>>> 134c134
>>>> <         HashMap ownerIdsToLists = new HashMap();
>>>> ---
>>>>
>>>>>        HashMap ownerIdsToLists = new HashMap(owners.size());
>>>>>
>>>>>
>>>>> --------------------------------------------------------------------

>>>>> ----
>>>>>
>>>>> Index: ConnectionFactoryPooledImpl.java
>>>>> ===================================================================
>>>>> RCS file:  
>>>>> /home/cvspublic/db-ojb/src/java/org/apache/ojb/broker/accesslayer/ 
>>>>> ConnectionFactoryPooledImpl.java,v
>>>>> retrieving revision 1.14
>>>>> diff -r1.14 ConnectionFactoryPooledImpl.java
>>>>> 112c112
>>>>> <             connectionPools = new HashMap();
>>>>> ---
>>>>>
>>>>>>            connectionPools = new HashMap(connectionPools.size());
>>>>>>
>>>>>>
>>>>>> -------------------------------------------------------------------

>>>>>> -----
>>>>>>
>>>>>> Index: MtoNCollectionPrefetcher.java
>>>>>> ===================================================================
>>>>>> RCS file:  
>>>>>> /home/cvspublic/db-ojb/src/java/org/apache/ojb/broker/accesslayer/

>>>>>> MtoNCollectionPrefetcher.java,v
>>>>>> retrieving revision 1.11
>>>>>> diff -r1.11 MtoNCollectionPrefetcher.java
>>>>>> 215,216c215,216
>>>>>> <         Collection queries = new ArrayList();
>>>>>> <         Collection idsSubset = new HashSet();
>>>>>> ---
>>>>>>
>>>>>>>        Collection queries = new ArrayList(owners.size());
>>>>>>>        Collection idsSubset = new HashSet(owners.size());
>>>>>>
>>>>>>
>>>>>> 271c271
>>>>>> <      * @param itemFk indirection table fks to item class
>>>>>> ---
>>>>>>
>>>>>>>     * @param itemFkCol indirection table fks to item class
>>>>>>
>>>>>>
>>>>>> 279c279
>>>>>> <         ArrayList values = new ArrayList();
>>>>>> ---
>>>>>>
>>>>>>>        ArrayList values = new ArrayList(ids.size());
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------------

>>>>>>> ------
>>>>>>>
>>>>>>> Index: PlainPrefetcher.java
>>>>>>> ==================================================================
=
>>>>>>> RCS file:  /home/cvspublic/db-ojb/src/java/org/apache/ojb/broker/

>>>>>>> accesslayer/PlainPrefetcher.java,v
>>>>>>> retrieving revision 1.8
>>>>>>> diff -r1.8 PlainPrefetcher.java
>>>>>>> 64c64
>>>>>>> <         HashMap realSubjectsMap = new HashMap();
>>>>>>> ---
>>>>>>>
>>>>>>>>        HashMap realSubjectsMap = new HashMap(  
>>>>>>>> realSubjects.size() );
>>>>>>>>
>>>>>>>>
>>>>>>>> -----------------------------------------------------------------

>>>>>>>> -------
>>>>>>>>
>>>>>>>> Index: ReferencePrefetcher.java
>>>>>>>> =================================================================

>>>>>>>> ==
>>>>>>>> RCS file:  
>>>>>>>> /home/cvspublic/db-ojb/src/java/org/apache/ojb/broker/ 
>>>>>>>> accesslayer/ReferencePrefetcher.java,v
>>>>>>>> retrieving revision 1.19
>>>>>>>> diff -r1.19 ReferencePrefetcher.java
>>>>>>>> 67c67
>>>>>>>> <         HashMap childrenMap = new HashMap();
>>>>>>>> ---
>>>>>>>>
>>>>>>>>>        HashMap childrenMap = new HashMap( children.size()
);
>>>>>>>>
>>>>>>>>
>>>>>>>> 112,113c112,113
>>>>>>>> <         Collection queries = new ArrayList();
>>>>>>>> <         Collection idsSubset = new HashSet();
>>>>>>>> ---
>>>>>>>>
>>>>>>>>>        Collection queries = new ArrayList( owners.size()
);
>>>>>>>>>        Collection idsSubset = new HashSet( owners.size()
);
>>>>>>>>
>>>>>>>>
>>>>>>>> 153c153
>>>>>>>> <      * @see  
>>>>>>>> org.apache.ojb.broker.accesslayer.RelationshipPrefetcherImpl#buil

>>>>>>>> dPrefetchQueries(Collection)
>>>>>>>> ---
>>>>>>>>
>>>>>>>>>     * @see  
>>>>>>>>> org.apache.ojb.broker.accesslayer.RelationshipPrefetcherImpl#bui

>>>>>>>>> ldPrefetchQuery(java.util.Collection,  
>>>>>>>>> org.apache.ojb.broker.metadata.FieldDescriptor[])
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> -----------------------------------------------------------------

>>>>>>>> -------
>>>>>>>>
>>>>>>>> -----------------------------------------------------------------

>>>>>>>> ----
>>>>>>>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>>>>>>>> For additional commands, e-mail: ojb-dev-help@db.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>> For additional commands, e-mail: ojb-dev-help@db.apache.org
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Mime
View raw message