db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jakob Braeuchi <jbraeu...@gmx.ch>
Subject Re: [PATCH]Redundant Casts
Date Mon, 17 May 2004 20:16:37 GMT
hi robert,

i check these kinds of issues some times.
But OQLLexer is a generated class so imo we should not care about unnecessary 
casts. the other class QueryImpl is under development.

jakob

Robert Sfeir wrote:

> Index: OQLLexer.java
> ===================================================================
> RCS file: /home/cvspublic/db-ojb/src/java/org/apache/ojb/odmg/oql/OQLLexer.java,v
> retrieving revision 1.18
> diff -r1.18 OQLLexer.java
> 261c261
> < 				else {throw new NoViableAltForCharException((char)LA(1), getFilename(), getLine(),
getColumn());}
> ---
> 
>>				else {throw new NoViableAltForCharException(LA(1), getFilename(), getLine(), getColumn());}
> 
> 628c628
> < 			throw new NoViableAltForCharException((char)LA(1), getFilename(), getLine(),
getColumn());
> ---
> 
>>			throw new NoViableAltForCharException(LA(1), getFilename(), getLine(), getColumn());
> 
> 673c673
> < 			throw new NoViableAltForCharException((char)LA(1), getFilename(), getLine(),
getColumn());
> ---
> 
>>			throw new NoViableAltForCharException(LA(1), getFilename(), getLine(), getColumn());
> 
> 749c749
> < 			throw new NoViableAltForCharException((char)LA(1), getFilename(), getLine(),
getColumn());
> ---
> 
>>			throw new NoViableAltForCharException(LA(1), getFilename(), getLine(), getColumn());
> 
> 761c761
> < 				if ( _cnt34>=1 ) { break _loop34; } else {throw new NoViableAltForCharException((char)LA(1),
getFilename(), getLine(), getColumn());}
> ---
> 
>>				if ( _cnt34>=1 ) { break _loop34; } else {throw new NoViableAltForCharException(LA(1),
getFilename(), getLine(), getColumn());}
> 
> 791c791
> < 					if ( _cnt37>=1 ) { break _loop37; } else {throw new NoViableAltForCharException((char)LA(1),
getFilename(), getLine(), getColumn());}
> ---
> 
>>					if ( _cnt37>=1 ) { break _loop37; } else {throw new NoViableAltForCharException(LA(1),
getFilename(), getLine(), getColumn());}
> 
> 821c821
> < 					if ( _cnt40>=1 ) { break _loop40; } else {throw new NoViableAltForCharException((char)LA(1),
getFilename(), getLine(), getColumn());}
> ---
> 
>>					if ( _cnt40>=1 ) { break _loop40; } else {throw new NoViableAltForCharException(LA(1),
getFilename(), getLine(), getColumn());}
> 
> 872c872
> < 			throw new NoViableAltForCharException((char)LA(1), getFilename(), getLine(),
getColumn());
> ---
> 
>>			throw new NoViableAltForCharException(LA(1), getFilename(), getLine(), getColumn());
> 
> 988c988
> < 			throw new NoViableAltForCharException((char)LA(1), getFilename(), getLine(),
getColumn());
> ---
> 
>>			throw new NoViableAltForCharException(LA(1), getFilename(), getLine(), getColumn());
>>
>>
>>------------------------------------------------------------------------
>>
>>Index: QueryImpl.java
>>===================================================================
>>RCS file: /home/cvspublic/db-ojb/src/java/org/apache/ojb/jdo/QueryImpl.java,v
>>retrieving revision 1.8
>>diff -r1.8 QueryImpl.java
>>167c167
>>< 		Collection results =  (Collection) m_conn.getCollectionByQuery(query);
>>---
>>
>>>		Collection results =  m_conn.getCollectionByQuery(query);
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> Robert S. Sfeir
>>> Technical Lead
>>> HHS Portal
>>> robert_sfeir@sra.com
>>>
>>>
>>>------------------------------------------------------------------------
>>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>>>For additional commands, e-mail: ojb-dev-help@db.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Mime
View raw message