db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert S. Sfeir" <rob...@codepuccino.com>
Subject [PATCH] Final Modifier
Date Thu, 15 Apr 2004 21:12:00 GMT
Finally have more time on my hands, so I ran through the IDEA code 
inspector and changed all the places where the final modifier could be 
added.  This was only done to method params and variables, not classes 
or methods themselves.  I ran the patches on the src/java directory only.

The document is at:

http://www.codepuccino.com/patches/finalmodifier.txt
(It's 1.1MB, but I've take great care this time to only show the changes 
in the diff)

I've run my local compile and junit tests, and as I mentioned to Brian 
in a separate email, the tests ran faster and memory usage was lower 
over all.

There are also about 74 different spots in the src/java directory where 
either of those conditions exist:

1- Possible runtime exceptions are not caught, notably some 
NullPointerExceptions with no try catch block

2- conditions which are always true or false.

Is there interest in me going through and whacking those out and 
submitting a patch, or would you prefer a report (in html) of where 
these places are so you can go and fix them at your leisure, or do you 
simply not care :-) ?

Thanks

R

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Mime
View raw message