db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jakob Braeuchi <jbraeu...@gmx.ch>
Subject Re: checkstyle for ojb ?
Date Wed, 10 Mar 2004 18:22:46 GMT


Thomas Dudziak wrote:

> On Mon, 8 Mar 2004, Jakob Braeuchi wrote:
> 
> 
>>there are several plugins for checkstyle. i use 
>>http://sourceforge.net/projects/eclipse-cs which runs inside eclipse m7.
> 
> 
> That's the one I tried. It died on me with an out-of-memory error (not
> Javas/Eclipses fault with 1gig of memory). I guess this is not a big 

it works fine on my machine with 512mb, maybe you have too much ram ;)

> issue, though, as we'd probably use it with an ant task.
> 
> 
>>imo we should not be too rigid about code-formatting (it ends up in religious 
>>discussions about where to put the braces ;) ) but we should enable checking of 
>>unused imports, unused variables and the like.
> 
> 
> I agree, though there are some code formatting issues that are important
> to error prevention IMO, e.g. always using braces in if-statements
> etc. For these things there should be rules.
> As Antonio said, some of these things are checked by Eclipse (e.g. unused
> imports, unused variables in M7 ?).

but we can not assume that everyone is using eclipse. althogh it would be nice.

> What I think is even more important is adding source documentation (and
> keeping it consistent with the source) and removing duplicate code and the

i agree.

jakob

> like because an unused import doesn't hurt (it's unlikely at
> least) whereas code duplication does hurt (when one instance has to be
> changed ...).
> 
> Tom
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Mime
View raw message