Return-Path: Delivered-To: apmail-db-ojb-dev-archive@www.apache.org Received: (qmail 42672 invoked from network); 20 Jan 2004 17:08:08 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 20 Jan 2004 17:08:08 -0000 Received: (qmail 89029 invoked by uid 500); 20 Jan 2004 17:07:42 -0000 Delivered-To: apmail-db-ojb-dev-archive@db.apache.org Received: (qmail 88984 invoked by uid 500); 20 Jan 2004 17:07:42 -0000 Mailing-List: contact ojb-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "OJB Developers List" Reply-To: "OJB Developers List" Delivered-To: mailing list ojb-dev@db.apache.org Received: (qmail 88943 invoked by uid 500); 20 Jan 2004 17:07:42 -0000 Received: (qmail 88922 invoked from network); 20 Jan 2004 17:07:42 -0000 Received: from unknown (HELO minotaur.apache.org) (209.237.227.194) by daedalus.apache.org with SMTP; 20 Jan 2004 17:07:42 -0000 Received: (qmail 42353 invoked by uid 1510); 20 Jan 2004 17:07:48 -0000 Date: 20 Jan 2004 17:07:48 -0000 Message-ID: <20040120170748.42352.qmail@minotaur.apache.org> From: arminw@apache.org To: db-ojb-cvs@apache.org Subject: cvs commit: db-ojb/src/java/org/apache/ojb/broker/accesslayer ConnectionManagerImpl.java X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N arminw 2004/01/20 09:07:48 Modified: src/java/org/apache/ojb/broker/accesslayer ConnectionManagerImpl.java Log: - only request autoCommit state of connection when necessary - throw PersistenceBrokerException with underlying SQLException Revision Changes Path 1.11 +10 -7 db-ojb/src/java/org/apache/ojb/broker/accesslayer/ConnectionManagerImpl.java Index: ConnectionManagerImpl.java =================================================================== RCS file: /home/cvs/db-ojb/src/java/org/apache/ojb/broker/accesslayer/ConnectionManagerImpl.java,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- ConnectionManagerImpl.java 18 Jan 2004 16:47:35 -0000 1.10 +++ ConnectionManagerImpl.java 20 Jan 2004 17:07:48 -0000 1.11 @@ -143,13 +143,16 @@ { con = this.connectionFactory.lookupConnection(jcd); if (con == null) throw new PersistenceBrokerException("Cannot get connection for " + jcd); - try + if (jcd.getUseAutoCommit() == JdbcConnectionDescriptor.AUTO_COMMIT_SET_TRUE_AND_TEMPORARY_FALSE) { - this.originalAutoCommitState = con.getAutoCommit(); - } - catch (SQLException e) - { - throw new PersistenceBrokerException("Cannot request autoCommit state on the connection"); + try + { + this.originalAutoCommitState = con.getAutoCommit(); + } + catch (SQLException e) + { + throw new PersistenceBrokerException("Cannot request autoCommit state on the connection", e); + } } if (log.isDebugEnabled()) log.debug("Request new connection from ConnectionFactory: " + con); } --------------------------------------------------------------------- To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org For additional commands, e-mail: ojb-dev-help@db.apache.org