Return-Path: Delivered-To: apmail-db-ojb-dev-archive@www.apache.org Received: (qmail 63438 invoked from network); 23 Nov 2003 09:02:23 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 23 Nov 2003 09:02:23 -0000 Received: (qmail 27704 invoked by uid 500); 23 Nov 2003 09:01:57 -0000 Delivered-To: apmail-db-ojb-dev-archive@db.apache.org Received: (qmail 27678 invoked by uid 500); 23 Nov 2003 09:01:57 -0000 Mailing-List: contact ojb-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "OJB Developers List" Reply-To: "OJB Developers List" Delivered-To: mailing list ojb-dev@db.apache.org Received: (qmail 27665 invoked from network); 23 Nov 2003 09:01:57 -0000 Received: from unknown (HELO mail.gmx.net) (213.165.64.20) by daedalus.apache.org with SMTP; 23 Nov 2003 09:01:57 -0000 Received: (qmail 11772 invoked by uid 65534); 23 Nov 2003 09:02:07 -0000 Received: from adsl-62-167-65-201.adslplus.ch (EHLO gmx.ch) (62.167.65.201) by mail.gmx.net (mp005) with SMTP; 23 Nov 2003 10:02:07 +0100 X-Authenticated: #15507884 Message-ID: <3FC07759.4040608@gmx.ch> Date: Sun, 23 Nov 2003 10:01:13 +0100 From: Jakob Braeuchi User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en-us, en MIME-Version: 1.0 To: OJB Developers List Subject: Re: [PATCH] DBUtility update of log handling and import cleanup References: <3FC00806.8070100@codepuccino.com> <34959.10.0.0.5.1069550874.squirrel@ags01.agsoftware.dnsalias.com> In-Reply-To: <34959.10.0.0.5.1069550874.squirrel@ags01.agsoftware.dnsalias.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N hi all, Antonio Gallardo wrote: > Robert S. Sfeir dijo: > >>-----BEGIN PGP SIGNED MESSAGE----- >>Hash: SHA1 >> >>Ok let's see if this is closer to what you expect :-) >> >>I also optimized the imports since per the apache docs something like >>java.sql.* is a no no. >>Let me know. > > > Great! :-D > > BTW, are you setted the tab to 4 spaces? This is another apache standard. > Also: > > if (expresion) > { > code; > } > > must be written: > > if (expresion) { > code; > } > i prefer : if (expr) { code; } jakob > of course this changes are minimal, but important too. > > Best Regards, > > Antonio Gallardo > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org > For additional commands, e-mail: ojb-dev-help@db.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org For additional commands, e-mail: ojb-dev-help@db.apache.org