db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert S. Sfeir" <rob...@codepuccino.com>
Subject Re: [PATCH] DBUtility update of log handling and import cleanup
Date Sun, 23 Nov 2003 01:38:19 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

yeah need to set spaces and not tabs, but I read that, and all the files are in the format
of:

if(exp)
{
~    code
}

the { is never on the same line in any of the files.  Should they be?
That would mean a pretty massive patch submission, since I can fix all that with a press of
2 keys using IntelliJ IDEA's reformating rules.  I'm SURE no one wants me to do that :-) lol

I'll move forward from there with the rest of the patch submissions.

R

Antonio Gallardo wrote:

| Robert S. Sfeir dijo:
|
|>-----BEGIN PGP SIGNED MESSAGE-----
|>Hash: SHA1
|>
|>Ok let's see if this is closer to what you expect :-)
|>
|>I also optimized the imports since per the apache docs something like
|>java.sql.* is a no no.
|>Let me know.
|
|
| Great! :-D
|
| BTW, are you setted the tab to 4 spaces? This is another apache standard.
| Also:
|
| if (expresion)
| {
| code;
| }
|
| must be written:
|
| if (expresion) {
| code;
| }
|
| of course this changes are minimal, but important too.
|
| Best Regards,
|
| Antonio Gallardo
|
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
| For additional commands, e-mail: ojb-dev-help@db.apache.org
|
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQE/wA+L+cV9vuB27SARAgoqAJ9CTIkNX+wSsLBeqeD4rRwCdF6CggCg9XzE
yTOkmzF0/co9zHvdfsScVng=
=no5g
-----END PGP SIGNATURE-----


---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Mime
View raw message