Return-Path: Mailing-List: contact ojb-dev-help@db.apache.org; run by ezmlm Delivered-To: mailing list ojb-dev@db.apache.org Received: (qmail 32194 invoked from network); 14 Feb 2003 09:01:03 -0000 Received: from mailout03.sul.t-online.com (194.25.134.81) by daedalus.apache.org with SMTP; 14 Feb 2003 09:01:03 -0000 Received: from fwd07.sul.t-online.de by mailout03.sul.t-online.com with smtp id 18jbic-00075Q-04; Fri, 14 Feb 2003 10:01:14 +0100 Received: from win (510007636964-0001@[80.145.76.188]) by fmrl07.sul.t-online.com with smtp id 18jbiJ-2CChweC; Fri, 14 Feb 2003 10:00:55 +0100 Message-ID: <003d01c2d407$94dfcdf0$6479fea9@win> Reply-To: "Armin Waibel" From: "Armin Waibel" To: "OJB Developers List" Subject: [CVS OJB tests fail] broker leak in cache Date: Fri, 14 Feb 2003 10:00:54 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4522.1200 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 X-Sender: 510007636964-0001@t-dialin.net X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Hi all, in CVS ObjectCacheDefaultImpl we had a PB leak. This is caused by using PBF.defaultPB calls without closing the broker. Jakob add this to avoid using of deprecated Identity constructor. But the real problem is that this solution never will work, because of using the default broker. Thus I propose the following changes in ObjectCache: a) remove the public void cache(Object obj) throws ClassNotPersistenceCapableException; method, this will never work. b) change method public void remove(Object obj); to public void remove(Identity oid); What do you think? regards, Armin