db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jakob Braeuchi <jbraeu...@gmx.ch>
Subject Re: Fix for bug in PersistenceBrokerImpl (Part 1)
Date Fri, 28 Feb 2003 16:56:15 GMT
hi thomas,

PersistenceBrokerImpl keeps getting bigger and bigger...
i think we should look for a way to reduce it's size. i was thinking of 
moving the handling of collections into separate classes, so PB only 
deals with single objects.

what do you think ?

jakob

Thomas Mahler wrote:

> Hi Jakob,
>
> Jakob Braeuchi wrote:
>
>> hi thomas,
>>
>> is delete m:n implementors no longer needed in storeCollections ?
>
>
> oops, sorry, I think I made a mistake when merging my local version 
> with the latest changes to PB.
>
> The modification in storeCollection is not a part of my fix...
>
> I'll correct it.
>
> thanks,
> Thomas
>
>
>> jakob
>>
>> Thomas Mahler wrote:
>>
>>> fixed it!
>>> thanks for the patch,
>>> Thomas
>>>
>>> Jamie Burns wrote:
>>>
>>>> Hi.
>>>>
>>>> I found what l believe to be a bug in PersistenceBrokerImpl.
>>>>
>>>> I have an EpisodeDetails object which has a collection of 
>>>> LegalSituations in an indirection table EpsDetLegSit. When a user 
>>>> deletes an EpsDetLegSit it is removed ok when the transaction is 
>>>> committed. However, if they try to add the EpsDetLegSit back in  in 
>>>> the same VM it does not get added when the transaction is committed.
>>>>
>>>> Back in November last year (2002/11/11) a change was made to the 
>>>> setInitialModificationState method in ObjectEnvelope. The change 
>>>> looked in a Map maintained by LoadedObjectsRegistry to see if the 
>>>> object had already been loaded in the VM. If the Map contained the 
>>>> object, ObjectEnvelope sets the initial state to StateOldClean. 
>>>> This is ok initially, but if the object is deleted it is not 
>>>> removed from LoadedObjectsRegistry. When the user tries to re-add 
>>>> the object, ObjectEnvelope still thinks the object exists and sets 
>>>> the state of the NEW object to StateOldClean.
>>>>
>>>> The changes l am submitting remove entries from the 
>>>> LoadedObjectsRegistry Map when PersistenceBrokerImpl removes 
>>>> entries from its ObjectCache. (Im sending the files in 2 seperate 
>>>> emails. My emails are getting bounced because of some size 
>>>> restriction)
>>>>
>>>> In the future someone might want to look at whether it is the 
>>>> responsibility of a PersistenceBroker or an ObjectCache to keep the 
>>>> LoadedObjectsRegistry in synch. For now, lve made it the 
>>>> responsibilty of a PersistenceBroker.
>>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>>> For additional commands, e-mail: ojb-dev-help@db.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>> For additional commands, e-mail: ojb-dev-help@db.apache.org
>>
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>


Mime
View raw message