db-ojb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jakob Braeuchi <jbraeu...@gmx.ch>
Subject Re: [CVS OJB tests fail] broker leak in cache
Date Fri, 14 Feb 2003 16:17:29 GMT
hi armin,

did it work _before_ my changes ? if yes i could undo them.

a) remove the public void cache(Object obj)
i agree. this method is imo never used in ojb.

b) change method remove(Object obj)
i think this should be ok


jakob


Armin Waibel wrote:

>Hi all,
>
>in CVS ObjectCacheDefaultImpl we had
>a PB leak.
>This is caused by using PBF.defaultPB calls
>without closing the broker. Jakob add this to avoid
>using of deprecated Identity constructor.
>But the real problem is that this solution never
>will work, because of using the default broker.
>
>Thus I propose the following changes in ObjectCache:
>a) remove the
>public void cache(Object obj) throws
>ClassNotPersistenceCapableException;
>method, this will never work.
>
>b) change method
>public void remove(Object obj);
>to
>public void remove(Identity oid);
>
>What do you think?
>
>
>regards,
>Armin
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
>  
>


Mime
View raw message