Return-Path: Mailing-List: contact ojb-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list ojb-dev@jakarta.apache.org Received: (qmail 27729 invoked by uid 98); 8 Jan 2003 10:07:59 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Received: (qmail 27690 invoked from network); 8 Jan 2003 10:07:57 -0000 Received: from daedalus.apache.org (HELO apache.org) (63.251.56.142) by nagoya.betaversion.org with SMTP; 8 Jan 2003 10:07:57 -0000 Received: (qmail 41426 invoked by uid 500); 8 Jan 2003 10:06:26 -0000 Received: (qmail 41418 invoked from network); 8 Jan 2003 10:06:26 -0000 Received: from cust.11.165.adsl.cistron.nl (HELO mail.topicus.nl) (62.216.11.165) by daedalus.apache.org with SMTP; 8 Jan 2003 10:06:26 -0000 Received: from kj.topicus.nl ([192.168.3.77]) by topicus.nl ([62.216.11.165]) with SMTP (MDaemon.PRO.v6.0.4.R) for ; Wed, 08 Jan 2003 11:06:36 +0100 Subject: [PATCH] reset odmg query parameter list From: Klaasjan Brand To: ojb-dev@jakarta.apache.org Content-Type: multipart/mixed; boundary="=-NffrnnIKYJPrPWo15xDW" Organization: Topicus B.V. Message-Id: <1042020392.31940.15.camel@topicus6> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.0 Date: 08 Jan 2003 11:06:32 +0100 X-MDRemoteIP: 192.168.3.77 X-Return-Path: klaasjan.brand@topicus.nl X-MDaemon-Deliver-To: ojb-dev@jakarta.apache.org X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N --=-NffrnnIKYJPrPWo15xDW Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, In OJB it's impossible to reuse an ODMG query because the parameter list iterator is not reset after query.execute(). This causes an exception when trying to bind new values to an already executed query. I've attached a small patch which resets the bind iterator after query execution. greets, Klaasjan Brand --=-NffrnnIKYJPrPWo15xDW Content-Disposition: attachment; filename=querypatch.txt Content-Type: text/plain; name=querypatch.txt; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Index: src/java/org/apache/ojb/odmg/oql/OQLQueryImpl.java =================================================================== RCS file: /home/cvspublic/jakarta-ojb/src/java/org/apache/ojb/odmg/oql/OQLQueryImpl.java,v retrieving revision 1.11 diff -u -r1.11 OQLQueryImpl.java --- src/java/org/apache/ojb/odmg/oql/OQLQueryImpl.java 5 Jan 2003 14:19:55 -0000 1.11 +++ src/java/org/apache/ojb/odmg/oql/OQLQueryImpl.java 8 Jan 2003 09:56:04 -0000 @@ -323,6 +323,10 @@ } } + // reset iterator to start of list so we can reuse this query + ListIterator it = getBindIterator(); + while( it.hasPrevious()) it.previous(); + capsule.destroy(); return result; } --=-NffrnnIKYJPrPWo15xDW--