db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew T. Adams (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (JDO-694) Automate OSGi bundling in JDO 3.1+ build
Date Thu, 13 Sep 2012 15:03:08 GMT

    [ https://issues.apache.org/jira/browse/JDO-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454931#comment-13454931
] 

Matthew T. Adams edited comment on JDO-694 at 9/14/12 2:02 AM:
---------------------------------------------------------------

[~clr]
> The notation that the javax.transaction package is optional was not captured in the resulting
MANIFEST.MF.
IIRC, our minimum supported Java version was 1.5.  If that's correct, then javax.transaction
and javax.naming are included in the JSE, so making them required shouldn't be an issue.

> There is no reference to the optional javax.persistence package. Perhaps this is because
we don't have an explicit reference to it.
I didn't understand that this was still needed in JDO 3.1.  Please clarify.

> The comment lines are broken in awkward places. Maybe we should update the project description
in trunk/pom.xml to avoid this?
The manifest isn't intended for the convenience of human readability; it has a fixed maximum
line length of 72 characters.  When viewed using a utility like bnd, the description is rendered
without the awkward line breaks.  We could add them, but I think that would make readability
where it's defined (${pom.description}) awkward.
                
      was (Author: matthewadams):
    [~clr]:
> The notation that the javax.transaction package is optional was not captured in the resulting
MANIFEST.MF.
IIRC, our minimum supported Java version was 1.5.  If that's correct, then javax.transaction
and javax.naming are included in the JSE, so making them required shouldn't be an issue.

> There is no reference to the optional javax.persistence package. Perhaps this is because
we don't have an explicit reference to it.
I didn't understand that this was still needed in JDO 3.1.  Please clarify.

> The comment lines are broken in awkward places. Maybe we should update the project description
in trunk/pom.xml to avoid this?
The manifest isn't intended for the convenience of human readability; it has a fixed maximum
line length of 72 characters.  When viewed using a utility like bnd, the description is rendered
without the awkward line breaks.  We could add them, but I think that would make readability
where it's defined (${pom.description}) awkward.
                  
> Automate OSGi bundling in JDO 3.1+ build
> ----------------------------------------
>
>                 Key: JDO-694
>                 URL: https://issues.apache.org/jira/browse/JDO-694
>             Project: JDO
>          Issue Type: Improvement
>          Components: api
>    Affects Versions: JDO 3 maintenance release 1 (3.1), JDO 3 maintenance release 2 (3.2)
>            Reporter: Matthew T. Adams
>            Assignee: Matthew T. Adams
>              Labels: jdo, osgi
>             Fix For: JDO 3 maintenance release 1 (3.1)
>
>         Attachments: jdo-694.patch
>
>
> Alter maven build to ensure that the JDO API jar expresses its dependencies on other
packages for the purposes of use in an OSGi environment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message