Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 50413 invoked from network); 29 Jun 2010 17:24:48 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 29 Jun 2010 17:24:48 -0000 Received: (qmail 3455 invoked by uid 500); 29 Jun 2010 17:24:48 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 3447 invoked by uid 99); 29 Jun 2010 17:24:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jun 2010 17:24:47 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jun 2010 17:24:45 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o5THGr4v003493 for ; Tue, 29 Jun 2010 17:16:53 GMT Message-ID: <16226096.118091277831813093.JavaMail.jira@thor> Date: Tue, 29 Jun 2010 13:16:53 -0400 (EDT) From: "Craig L Russell (JIRA)" To: jdo-dev@db.apache.org Subject: [jira] Resolved: (JDO-653) Extra checks in PMF.close tests In-Reply-To: <12166372.9451272295291441.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JDO-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig L Russell resolved JDO-653. --------------------------------- Fix Version/s: JDO 3 Resolution: Fixed Patch applied to trunk: svn commit -m "JDO-653 Thanks to Peter Dettman for the patch" src/java Sending src/java/org/apache/jdo/tck/api/persistencemanagerfactory/AfterCloseSetMethodsThrowException.java Sending src/java/org/apache/jdo/tck/api/persistencemanagerfactory/Close.java Sending src/java/org/apache/jdo/tck/api/persistencemanagerfactory/CloseFailsIfTransactionActive.java Sending src/java/org/apache/jdo/tck/api/persistencemanagerfactory/CloseWithoutPermissionThrowsSecurityException.java Transmitting file data .... Committed revision 959037. Patch applied to branches/3.0: svn commit -m "JDO-653 Thanks to Peter Dettman for the patch" src/java Sending src/java/org/apache/jdo/tck/api/persistencemanagerfactory/AfterCloseSetMethodsThrowException.java Sending src/java/org/apache/jdo/tck/api/persistencemanagerfactory/Close.java Sending src/java/org/apache/jdo/tck/api/persistencemanagerfactory/CloseFailsIfTransactionActive.java Sending src/java/org/apache/jdo/tck/api/persistencemanagerfactory/CloseWithoutPermissionThrowsSecurityException.java Transmitting file data .... Committed revision 959039. > Extra checks in PMF.close tests > ------------------------------- > > Key: JDO-653 > URL: https://issues.apache.org/jira/browse/JDO-653 > Project: JDO > Issue Type: Test > Components: tck > Affects Versions: JDO 2 maintenance release 2 > Reporter: Peter Dettman > Assignee: Michelle Caisse > Fix For: JDO 3 > > Attachments: JDO-653-2nd.patch, JDO-653-tck.patch, JDO-653.patch > > > Some of the implications of section 11.4 don't appear to be checked for in the case of an already-closed PersistenceManagerFactory. > 1. If close() is called on an already-closed PMF (with correct permission i.e. "closePersistenceManagerFactory"), no exception should be thrown. > 2. If close() is called on an already-closed PMF (without correct permission), exception should be thrown (even though it would otherwise do nothing). > 3. If close() fails (throws JDOUserException) due to active transaction(s), then none of the PersistenceManager objects belonging to the PMF should have actually been closed. > 4. Several get/set pairs are not tested for their behaviour after close() -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.