db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Dettman (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-653) Extra checks in PMF.close tests
Date Sat, 26 Jun 2010 08:11:55 GMT

    [ https://issues.apache.org/jira/browse/JDO-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882823#action_12882823

Peter Dettman commented on JDO-653:

The reference implementation for JDO3 is DataNucleus 2.1.0, which passes these new test cases.

The revised patch, which adds the test cases to "tck", can therefore now be safely applied,
and I have confirmed that indeed all tests run without errors or failures (but in particular
pmf.conf, which this patch affects).

> Extra checks in PMF.close tests
> -------------------------------
>                 Key: JDO-653
>                 URL: https://issues.apache.org/jira/browse/JDO-653
>             Project: JDO
>          Issue Type: Test
>          Components: tck
>    Affects Versions: JDO 2 maintenance release 2
>            Reporter: Peter Dettman
>            Assignee: Michelle Caisse
>         Attachments: JDO-653-2nd.patch, JDO-653-tck.patch, JDO-653.patch
> Some of the implications of section 11.4 don't appear to be checked for in the case of
an already-closed PersistenceManagerFactory.
> 1. If close() is called on an already-closed PMF (with correct permission i.e. "closePersistenceManagerFactory"),
no exception should be thrown.
> 2. If close() is called on an already-closed PMF (without correct permission), exception
should be thrown (even though it would otherwise do nothing).
> 3. If close() fails (throws JDOUserException) due to active transaction(s), then none
of the PersistenceManager objects belonging to the PMF should have actually been closed.
> 4. Several get/set pairs are not tested for their behaviour after close()

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message