db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig L Russell <craig.russ...@oracle.com>
Subject Re: [jira] Updated: (JDO-653) Extra checks in PMF.close tests
Date Fri, 30 Apr 2010 01:49:06 GMT
Hi Peter,

Thanks for the patch. I'll take a look.

Craig

On Apr 26, 2010, at 9:27 AM, Peter Dettman (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/JDO-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

>  ]
>
> Peter Dettman updated JDO-653:
> ------------------------------
>
>    Attachment: JDO-653.patch
>
> Attaching a patch to add the missing checks described above.
>
> Note: there was also a "fail" missing in  
> CloseWithoutPermissionThrowsSecurityException for the case where no  
> exception is thrown (but one is expected).
>
>> Extra checks in PMF.close tests
>> -------------------------------
>>
>>                Key: JDO-653
>>                URL: https://issues.apache.org/jira/browse/JDO-653
>>            Project: JDO
>>         Issue Type: Test
>>         Components: tck2
>>   Affects Versions: JDO 2 maintenance release 2
>>           Reporter: Peter Dettman
>>        Attachments: JDO-653.patch
>>
>>
>> Some of the implications of section 11.4 don't appear to be checked  
>> for in the case of an already-closed PersistenceManagerFactory.
>> 1. If close() is called on an already-closed PMF (with correct  
>> permission i.e. "closePersistenceManagerFactory"), no exception  
>> should be thrown.
>> 2. If close() is called on an already-closed PMF (without correct  
>> permission), exception should be thrown (even though it would  
>> otherwise do nothing).
>> 3. If close() fails (throws JDOUserException) due to active  
>> transaction(s), then none of the PersistenceManager objects  
>> belonging to the PMF should have actually been closed.
>> 4. Several get/set pairs are not tested for their behaviour after  
>> close()
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!


Mime
View raw message