From jdo-dev-return-8293-apmail-db-jdo-dev-archive=www.apache.org@db.apache.org Fri Sep 18 15:58:38 2009 Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 36316 invoked from network); 18 Sep 2009 15:58:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 18 Sep 2009 15:58:38 -0000 Received: (qmail 63729 invoked by uid 500); 18 Sep 2009 15:58:38 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 63680 invoked by uid 99); 18 Sep 2009 15:58:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Sep 2009 15:58:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Sep 2009 15:58:36 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 17C6E234C1E9 for ; Fri, 18 Sep 2009 08:58:16 -0700 (PDT) Message-ID: <579249744.1253289496096.JavaMail.jira@brutus> Date: Fri, 18 Sep 2009 08:58:16 -0700 (PDT) From: "Craig Russell (JIRA)" To: jdo-dev@db.apache.org Subject: [jira] Commented: (JDO-639) tck enhancement should make use of feature to enhance an entire directory In-Reply-To: <985288682.1252697817923.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757218#action_12757218 ] Craig Russell commented on JDO-639: ----------------------------------- This seems to capture the essence of the issue. > tck enhancement should make use of feature to enhance an entire directory > ------------------------------------------------------------------------- > > Key: JDO-639 > URL: https://issues.apache.org/jira/browse/JDO-639 > Project: JDO > Issue Type: Improvement > Components: tck2 > Affects Versions: JDO 2 maintenance release 2 > Reporter: Michael Bouschen > Assignee: Michelle Caisse > > The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files. > There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files: > - Property jdo.tck.pcclasses.sources is used when checking whether (re)enahceing is required. Maybe a pattern > org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java > can be used instead of listing all the persistnt capable classes explicitly. > - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattrern could replace the list of class files. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.