On Dec 22, 2008, at 10:37 AM, Craig L Russell wrote: > Hi Ilan, > > On Dec 22, 2008, at 10:24 AM, Ilan Kirsh wrote: > >> Hi Craig, >> >>>> Is class name supported? >>> That's an open question in my mind. How would you propose that >>> the enhancer find the file corresponding to the class? >>> 1. The class loader might not want to give you access to the >>> file, especially for example if it was loaded from a jar. In that >>> case, what you need is the path to the jar or the resource name >>> of the jar. >>> 2. As far as I know, there's no reverse translation of class >>> loader + class name to file name. >> >> It is just more user friendly to let the user specify a class name >> and let >> the implementation convert the class name into resource name by >> adding >> a ".class" suffix and replacing '.' with '/'. > > This will fail if the class to be enhanced is in a jar file, right? > Do we warn users about this problem? Another thing is member ("inner") classes whose names have a "." separator as a class name and a "$" separator as a file name. Do we really want to require the enhancer to contain the logic to figure out what the file name for a member class is? Craig > > > Craig >> >> >> I don't suggest other changes, so the class will be loaded as a >> resource >> and "-d" will still be required in this case. >> >> Ilan > > Craig L Russell > Architect, Sun Java Enterprise System http://db.apache.org/jdo > 408 276-5638 mailto:Craig.Russell@sun.com > P.S. A good JDO? O, Gasp! > Craig L Russell Architect, Sun Java Enterprise System http://db.apache.org/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp!