db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Jefferson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-591) Enhancer Invocation API
Date Sat, 13 Dec 2008 09:17:44 GMT

    [ https://issues.apache.org/jira/browse/JDO-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656267#action_12656267
] 

Andy Jefferson commented on JDO-591:
------------------------------------

In conjunction with JDO-621 we need to decide if the current API is final. I added
addClass(String className, byte[] bytes); // for generated class
addClasses(String... classes); // For classes (in classpath, or files)
addFiles(String filenames); // For mapping files
addJar(String jarFilename); // For jar file

so we mirror more-or-less the same entries in persistence.xml. Maybe the addFiles() should
be called addMappingFiles()
to use the persistence.xml name


The other thing is if we allow specification of some directory, and subdirectories, where
does that come in. The API needs to be clear, and adding this subdirectories control would
have no bearing on some of the above options. Could add

addDirectory(String dirName, boolean subdirs);

> Enhancer Invocation API
> -----------------------
>
>                 Key: JDO-591
>                 URL: https://issues.apache.org/jira/browse/JDO-591
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Andy Jefferson
>            Assignee: Andy Jefferson
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdoenhancer-5.patch
>
>
> Having a standard interface to invoke the enhancer makes a lot of sense so we can have
interchangeability of enhancers (for implementations that support BinaryCompatibility). 
> A start point (for discussions) could be
> java -cp classpath  {enhancer-class} [options] [jdo-files] [class-files]
>     where options can be
>         -persistenceUnit persistence-unit-name : Name of a "persistence-unit" to enhance
the classes for
>         -d target-dir-name : Write the enhanced classes to the specified directory
>         -checkonly : Just check the classes for enhancement status
>         -v : verbose output
> This then allows enhancement of the specified classes, or the classes defined by the
specified JDO files, or the classes defined by the specified persistence-unit.
> What other control would people like to see ? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message