Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 64376 invoked from network); 14 Nov 2008 21:56:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Nov 2008 21:56:44 -0000 Received: (qmail 14952 invoked by uid 500); 14 Nov 2008 21:56:52 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 14939 invoked by uid 99); 14 Nov 2008 21:56:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Nov 2008 13:56:51 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Nov 2008 21:55:39 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id DEFB5234C297 for ; Fri, 14 Nov 2008 13:55:53 -0800 (PST) Message-ID: <1227957193.1226699753912.JavaMail.jira@brutus> Date: Fri, 14 Nov 2008 13:55:53 -0800 (PST) From: "Michelle Caisse (JIRA)" To: jdo-dev@db.apache.org Subject: [jira] Closed: (JDO-611) GetObjectIdForPersistentInterface - Implementation Class / PICompany / ICompany Mess In-Reply-To: <1559281054.1225894184158.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JDO-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michelle Caisse closed JDO-611. ------------------------------- Resolution: Fixed Fix Version/s: JDO 2 maintenance release 2 update 1 JDO 2 maintenance release 3 Fixed in trunk and 2.2.1 > GetObjectIdForPersistentInterface - Implementation Class / PICompany / ICompany Mess > ------------------------------------------------------------------------------------- > > Key: JDO-611 > URL: https://issues.apache.org/jira/browse/JDO-611 > Project: JDO > Issue Type: Test > Components: tck2 > Affects Versions: JDO 2 maintenance release 2 > Reporter: Ilan Kirsh > Assignee: Michelle Caisse > Fix For: JDO 2 maintenance release 3, JDO 2 maintenance release 2 update 1 > > > I have two issues with this test: > (1) > IMO, PICompany should be written instead of ICompany: > (a) > ICompany icompany = (ICompany)pm.newInstance(PICompany.class); > instead of: > ICompany icompany = (ICompany)pm.newInstance(ICompany.class); > and: > (b) > addTearDownClass(PICompany.class); > instead of: > addTearDownClass(ICompany.class); > ICompany is not persistence capable, so the implementation does not have to handle it. > (2) > I think that the following check is wrong: > if (icompanyOidClass != icompany.getClass()) > icompany.getClass() => the physical internal implementation class > icompanyOidClass => the logical interface (PICompany) > Actually and exception should be thrown if (icompanyOidClass == icompany.getClass()) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.