db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Jefferson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-591) Enhancer Invocation API
Date Fri, 17 Oct 2008 18:21:44 GMT

    [ https://issues.apache.org/jira/browse/JDO-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640611#action_12640611
] 

Andy Jefferson commented on JDO-591:
------------------------------------

Hi Richard,
There is no way of knowing the "enhance date".
Things like "methodsAdded", "bytesAdded" etc should only ever be returnable from enhanceXXX()
rather than as a separate method; it is the enhance process that would define these.
Presumably "enhanceVendor" is to return the vendor name of the enhancer being used?

I don't see the need for 
public Class enhance(String className);
since 
void enhanceClasses(String... classNames);
provides that. 

Similarly the signature "enhance(String className, File jdoConfigFile);" since the class name
implies the location of the config file (JDO compliant locations in the CLASSPATH).

What is "JDO configuration" ? Why would you set it ?

> Enhancer Invocation API
> -----------------------
>
>                 Key: JDO-591
>                 URL: https://issues.apache.org/jira/browse/JDO-591
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Andy Jefferson
>            Assignee: Andy Jefferson
>             Fix For: JDO 2 maintenance release 3
>
>
> Having a standard interface to invoke the enhancer makes a lot of sense so we can have
interchangeability of enhancers (for implementations that support BinaryCompatibility). 
> A start point (for discussions) could be
> java -cp classpath  {enhancer-class} [options] [jdo-files] [class-files]
>     where options can be
>         -persistenceUnit persistence-unit-name : Name of a "persistence-unit" to enhance
the classes for
>         -d target-dir-name : Write the enhanced classes to the specified directory
>         -checkonly : Just check the classes for enhancement status
>         -v : verbose output
> This then allows enhancement of the specified classes, or the classes defined by the
specified JDO files, or the classes defined by the specified persistence-unit.
> What other control would people like to see ? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message