db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Schilling <rschill...@cognitiongroup.biz>
Subject Re: [jira] Commented: (JDO-582) Test case needed for JDOFatalUserException nested exception argument needs cast to Throwable[]
Date Fri, 25 Jul 2008 19:16:18 GMT
O.K.  You can back out that patch and apply the latest one I just 
uploaded.  It compiles on my machine without error now.

But, I also have a new question.  If the method 
JDOFatalUserException.getNestedExceptions() returns a Throwable[], then 
what exactly should the test case be checking for?  My understanding was 
that I'm supposed to test the nested exceptions array to be sure it's 
composed of a Throwable[] array, but the method declaration enforces 
that..........

perhaps I need to be told again what we're testing for ....



Richard


Richard Schilling wrote:
> O.K. My bad.  I have t ocall the method getNestedExceptions() on the 
> exception that is returned.  Change forthcomming. .....
>
> Richard
>
>
>
> Michelle Caisse (JIRA) wrote:
>>     [ 
>> https://issues.apache.org/jira/browse/JDO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616967#action_12616967

>> ]
>> Michelle Caisse commented on JDO-582:
>> -------------------------------------
>>
>> I get a compile error:
>> test:compile:
>>     [javac] Compiling 9 source files to 
>> C:\jdo\trunk\api2\target\test-classes
>> C:\jdo\trunk\api2\test\java\javax\jdo\JDOHelperTest.java:236: 
>> inconvertible types found   : java.lang.Throwable
>> required: java.lang.Throwable[]
>>                 if (!(ex.getCause() instanceof Throwable[]))
>>                                  ^
>> Note: Some input files use unchecked or unsafe operations.
>> Note: Recompile with -Xlint:unchecked for details.
>> 1 error
>>
>>  
>>> Test case needed for JDOFatalUserException nested exception argument 
>>> needs cast to Throwable[]
>>> ----------------------------------------------------------------------------------------------

>>>
>>>
>>>                 Key: JDO-582
>>>                 URL: https://issues.apache.org/jira/browse/JDO-582
>>>             Project: JDO
>>>          Issue Type: Bug
>>>          Components: api2, api2-legacy
>>>            Reporter: Erik Bengtson
>>>            Assignee: Richard Schilling
>>>             Fix For: JDO 2 maintenance release 2
>>>
>>>         Attachments: 20080710-jdo-582.diff, 
>>> estedExceptionJDOHelper.patch
>>>
>>>
>>> After collecting exceptions from invoking 
>>> getPersistenceManagerFactory on all implementations, if no 
>>> implementation has succeeded in returning a 
>>> PersistenceManagerFactory, an exception is thrown, and the argument 
>>> should be a Throwable[]. Otherwise, it's treated as a failed object 
>>> instead of nested exceptions.
>>>     
>>
>>   
>
>
>


Mime
View raw message