db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JDO-555) All calls to Class.getMethod and Method.invoke (among others) need to be invoked inside a doPrivileged block.
Date Tue, 15 Jul 2008 01:01:34 GMT

     [ https://issues.apache.org/jira/browse/JDO-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Craig Russell updated JDO-555:
------------------------------

    Attachment: xmlbean.patch

This patch adds doPrivileged to calls to spring bean processing.

The method getBean is the method that is invoked in doPrivileged. The same method is used
in QueryTest and in CompletenessTest. It might appear in other places in the tck as well.

So, should we put getBean into JDO_Test? Create a new subclass of JDO_Test that would be inherited
by QueryTest and CompletenessTest? I don't  like the duplication of the method in two places.

Another issue is the treatment of the root list. In QueryTest, two different class implementations
both use the same pattern: call the root list bean "root". This patch assumes that getRootList
which has no actual common implementation between the MylibReader and CompanyReader, simply
returns the xml bean called "root". We could also create a common BeanReader class that both
MylibReader and CompanyReader inherit.

Suggestions?




> All calls to Class.getMethod and Method.invoke (among others) need to be invoked inside
a doPrivileged block.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: JDO-555
>                 URL: https://issues.apache.org/jira/browse/JDO-555
>             Project: JDO
>          Issue Type: Bug
>          Components: api2, api2-legacy
>    Affects Versions: JDO 2 maintenance release 1
>            Reporter: Matthew T. Adams
>            Assignee: Andy Jefferson
>             Fix For: JDO 2 maintenance release 2
>
>         Attachments: datanucleus.patch, datanucleus.patch, jdo-555.patch, jdo-555.patch,
jdo-555.patch, xmlbean.patch
>
>
> Discovered in review of patch to JDO-545.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message