db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object
Date Wed, 19 Sep 2007 20:00:16 GMT

    [ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528878
] 

Craig Russell commented on JDO-528:
-----------------------------------

Looks good; just a comment or two:

Reading the language spec, it might be better if we make the ObjectState constructor private,
i.e.
+    ObjectState(String value) {
+        this.value = value;
+    }
+

becomes
+    private ObjectState(String value) {
+        this.value = value;
+    }
+

Curious that there is no example in the language specification that has an example of this
kind of usage.

And there's no newline at end of file. And the file should be svn:eol-style=LF.

Updates to JDOHelper look good, although the algorithm for persistent transactional could
be tighter.


> JDOHelper.getObjectState() : convenience method to return the state of an object
> --------------------------------------------------------------------------------
>
>                 Key: JDO-528
>                 URL: https://issues.apache.org/jira/browse/JDO-528
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Andy Jefferson
>            Priority: Minor
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDOHelper.patch, ObjectState.patch
>
>
> As discussed on the jdo-dev mailing list cerca 5th August 2007, it would be desirable
for JDOHelper to have a method to return the object "state" of a passed object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message