Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jdo-dev@db.apache.org
Received-SPF: pass (athena.apache.org: domain of cbeams@gmail.com designates
 209.85.198.189 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:mime-version:in-reply-to:references:content-type:message-id:from:subject:date:to:x-mailer;
        b=tqAwwZe/69oQzdxWusLjNGQ4DcU1j3SXaZoS7nRpM+Cv+MYZQYhDuj8cG0XaS9SjU/tbMn3ghbsIXcqiin4F85X7sD4++DvXzZ6+b8jL1tGRX+gbjg06oH6Tr5brngvTOTCWicCJcmcETfqSsQgpetEP35wSaSCtkjguHqWVufI=
Mime-Version: 1.0 (Apple Message framework v752.3)
In-Reply-To: <45CA023F-9583-4BA6-BD8F-1A2F7149F5C2@gmail.com>
References: <45CA023F-9583-4BA6-BD8F-1A2F7149F5C2@gmail.com>
Content-Type: multipart/alternative; boundary=Apple-Mail-102--236133112
Message-Id: <327A6464-2DF1-482A-8342-6E931DD9B48A@gmail.com>
From: cbeams <cbeams@gmail.com>
Subject: Re: 2.1 Spec: detached-dirty parameters to makePersistent() when
 DetachAllOnCommit=true
Date: Sun, 5 Aug 2007 22:09:40 -0700
To: jdo-dev@db.apache.org,
 JDO Expert Group <jdo-experts-ext@Sun.COM>

--Apple-Mail-102--236133112
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed

My previous email on this topic was a bit verbose, and I later  
realized contained some inaccuracies.  Keeping things as succinct as  
possible, is there any reason the spec couldn't be amended to support  
the following code?


package com.xyz;

import org.apache.log4j.Logger;

import javax.jdo.*;
import static javax.jdo.JDOHelper.*;


public class Main {
     public static final Logger logger = Logger.getLogger(Main.class);

     public static void main(String... args) {
         PersistenceManagerFactory pmf =
             JDOHelper.getPersistenceManagerFactory("jpox.properties");
         PersistenceManager pm = pmf.getPersistenceManager();

         assert pm.getDetachAllOnCommit() == true;

         A parameter = new A();
         A returned;

         logger.info("making newly created parameter instance  
persistent");
         pm.currentTransaction().begin();
         returned = pm.makePersistent(parameter);
         pm.currentTransaction().commit();

         assert parameter == returned;
         assert isDetached(parameter) && !isDirty(parameter);

         logger.info("dirtying parameter instance");
         parameter.setName("mud");
         assert isDetached(parameter) && isDirty(parameter);

         logger.info("reattaching dirtied parameter instance");
         pm.currentTransaction().begin();
         returned = pm.makePersistent(parameter);
         pm.currentTransaction().commit();

         // these assertions currently fail
         assert parameter == returned;
         assert isDetached(parameter) && !isDirty(parameter);
     }
}


@javax.jdo.annotations.PersistenceCapable(detachable = "true")
class A {
     private String name;
     public void setName(String name) { this.name = name; }
}


Thanks,

- Chris Beams


--Apple-Mail-102--236133112--