Return-Path: 
 <jdo-dev-return-6014-apmail-db-jdo-dev-archive=www.apache.org@db.apache.org>
Delivered-To: apmail-db-jdo-dev-archive@www.apache.org
Received: (qmail 76081 invoked from network); 19 Jul 2007 05:10:31 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 19 Jul 2007 05:10:31 -0000
Received: (qmail 32702 invoked by uid 500); 19 Jul 2007 05:10:12 -0000
Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:jdo-dev-help@db.apache.org>
List-Unsubscribe: <mailto:jdo-dev-unsubscribe@db.apache.org>
List-Post: <mailto:jdo-dev@db.apache.org>
List-Id: <jdo-dev.db.apache.org>
Reply-To: jdo-dev@db.apache.org
Delivered-To: mailing list jdo-dev@db.apache.org
Received: (qmail 32691 invoked by uid 99); 19 Jul 2007 05:10:12 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jul 2007 22:10:12 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (herse.apache.org: local policy)
Received: from [212.159.14.213] (HELO ptb-relay02.plus.net) (212.159.14.213)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jul 2007 22:10:09 -0700
Received: from [87.112.86.66] (helo=[192.168.0.22])
	 by ptb-relay02.plus.net with esmtp (Exim) id 1IBOGp-0001EJ-E8;
 Thu, 19 Jul 2007 06:09:47 +0100
From: Andy Jefferson <andy@jpox.org>
To: jdo-dev@db.apache.org,
 JDO Expert Group <jdo-experts-ext@sun.com>
Subject: Re: Annotations for embedded Key, Value, and Element
Date: Thu, 19 Jul 2007 06:09:46 +0100
User-Agent: KMail/1.9.6
References: <3CDEE148-64FC-4BE2-B6F4-6684782CD8FD@SUN.com>
 <200707180846.56183.andy@jpox.org>
 <E790B4FE-90B2-420F-B7AF-0CD6453E9321@SUN.com>
In-Reply-To: <E790B4FE-90B2-420F-B7AF-0CD6453E9321@SUN.com>
Organization: JPOX
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200707190609.46962.andy@jpox.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Hi Craig,

> >> The only thing needed is the Embedded[] embedded() default {} element
> >> of @Key, @Value, and @Element, replacing the String embedded() that I
> >> think has no use here.
> >
> > @Element "embedded" (String) has the same use as
> > <collection embedded-element=3D"...">
>
> Yes, this is part of the separation of jdo from orm metadata. It
> might make sense to preserve the name of the attributes and put the
> corresponding annotation elements embeddedElement, embeddedKey, and
> embeddedValue  into @Field and @Property and then use embedded() for
> mapping.

I disagree on that placement of the other flags, back on to @Field/@Propert=
y.=20
They relate specifically to the element, key, value so keep them on the=20
associated annotation would be my vote. So then it really comes down to=20
namings of the global flag, and the mapping details

1. "embedded", "embeddedMapping"
2. "embeddedElement", "embedded"



> Have you looked at how to do mapping of embedded element, key, and
> value with the current annotations? I might have missed something
> obvious...

Looks fine to me. Should cater for all cases I have immediately to mind


=2D-=20
Andy =A0(Java Persistent Objects - http://www.jpox.org)