Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 63915 invoked from network); 19 May 2007 00:48:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 May 2007 00:48:42 -0000 Received: (qmail 66103 invoked by uid 500); 19 May 2007 00:48:48 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 66092 invoked by uid 99); 19 May 2007 00:48:48 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 May 2007 17:48:48 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 May 2007 17:48:41 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 2977271406F for ; Fri, 18 May 2007 17:48:21 -0700 (PDT) Message-ID: <2414632.1179535701167.JavaMail.jira@brutus> Date: Fri, 18 May 2007 17:48:21 -0700 (PDT) From: "Craig Russell (JIRA)" To: jdo-dev@db.apache.org Subject: [jira] Commented: (JDO-433) setUp() is not declared final in org.apache.jdo.tck.JDO_Test In-Reply-To: <32284188.1160597798275.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JDO-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497099 ] Craig Russell commented on JDO-433: ----------------------------------- Looks good. Just one comment. I don't think we need the localSetUp method to call closePMF, since that is always done by tearDown (9 places). > setUp() is not declared final in org.apache.jdo.tck.JDO_Test > ------------------------------------------------------------ > > Key: JDO-433 > URL: https://issues.apache.org/jira/browse/JDO-433 > Project: JDO > Issue Type: Bug > Components: tck2 > Affects Versions: JDO 2 final > Reporter: Michelle Caisse > Assigned To: Michelle Caisse > Priority: Minor > Fix For: JDO 2 maintenance release 1 > > Attachments: JDO-433.patch > > > Tests are to override localSetUp() for test specific set up. The setUp() method in JDO_Test is not meant to be overriden. However, it is not currently declared to be final. It should be declared final and the set up code in the tests that do override setUp() (listed below) should be in localSetUp(). > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManager.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManagerFactoryByPropertiesInstance.java:60: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerFactoryByPropertiesInstance cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManagerForUser.java:63: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionPassword.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionPassword cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionURL.java:58: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionURL cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionUserName.java:57: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionUserName cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetIgnoreCache.java:53: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetIgnoreCache cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetMultithreaded.java:57: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetMultithreaded cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetNonTransactionalRead.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalRead cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetNonTransactionalWrite.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalWrite cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetOptimistic.java:53: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetOptimistic cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ > C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetRetainValues.java:55: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetRetainValues cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final > protected void setUp() throws Exception { > ^ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.