db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-444) Add public constructor for JDOHelper
Date Tue, 19 Dec 2006 18:20:21 GMT
    [ http://issues.apache.org/jira/browse/JDO-444?page=comments#action_12459713 ] 
            
Michael Bouschen commented on JDO-444:
--------------------------------------

The patch JDOHelper.diff looks good! 

Just one comment: how about adding a comment to the test methods testConstructor and testGetInstance
saying that the purpose of the test is calling the JDOHelper methods on the instance and making
sure they do not throw an exception.

> Add public constructor for JDOHelper
> ------------------------------------
>
>                 Key: JDO-444
>                 URL: http://issues.apache.org/jira/browse/JDO-444
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2, specification, api2-legacy
>            Reporter: Michelle Caisse
>         Assigned To: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDOHelper.diff
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns,
an instance of JDOHelper on which to invoke methods is preferable to the use of static methods.
For this purpose, a public constructor is provided.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message